Valkey helm #419

sgissi · 2025-11-23T22:46:13Z

Description

This PR supersedes #408, to add a new blog post about the new official Valkey Helm Chart, including reasons for the chart creation and migration steps from the existing chart.

Issues Resolved

Closes #408

Check List

[ X ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

Signed-off-by: cherukum-amazon <cherukum@amazon.com>

Signed-off-by: Silvio Gissi <silvio@gissilabs.com>

sgissi · 2025-11-23T22:48:03Z

@cherukum-Amazon @stockholmux Can you take a look at this update please? It has a dependency on a new release of valkey-helm supporting replicas (valkey-io/valkey-helm#84) which I'm merging shortly.

content/blog/2025-11-05-valkey-helm-chart/index.md

cherukum-Amazon · 2025-11-25T18:12:36Z

content/blog/2025-11-05-valkey-helm-chart/index.md

+OK
+$ $NEW_VALKEY_CLI info | grep '^\(role\|master_host\|master_link_status\)'
+role:slave
+master_host:valkey-bitnami-primary


is this the instance name, can we map to an existing environment variable?.

Also keep environment variables in one place with comments, so its easy to back track.

The shell variable here is misleading. I'll update to create a shell alias instead.

content/blog/2025-11-05-valkey-helm-chart/index.md

cherukum-Amazon · 2025-11-25T18:13:17Z

content/blog/2025-11-05-valkey-helm-chart/index.md

+Update all clients to use the new Valkey read-write and read-only endpoints which are exposed as services (`SERVICE.NAMESPACE.svc.cluster.local`). In the example above:
+
+* Read-Write (primary): `valkey.apps-test.svc.cluster.local`
+* Read-Only (all instances): `valkey-read.apps-test.svc.cluster.local`


can we tag the endpoints to environment variables?.

cherukum-Amazon · 2025-11-25T18:14:29Z

content/blog/2025-11-05-valkey-helm-chart/index.md

+
+```shell
+$ kubectl get pods --all-namespaces -l app.kubernetes.io/name=valkey -o custom-columns=Pod:.metadata.name,Namespace:.metadata.namespace,Instance:.metadata.labels.app\\.kubernetes\\.io\\/instance
+Pod                                 Namespace   Instance


is 53 to 57 sample outcome from the command?. can we call it out explicitly with a comment

I updated all shells where output is shown with # * Sample Output *, not sure it is clearer or not. By default if a shell command is listed with a $ in front, it means to show the shell command and output.

cherukum-Amazon · 2025-11-25T20:26:31Z

content/blog/2025-11-05-valkey-helm-chart/index.md

+$ $NEW_VALKEY_CLI replicaof $SVCPRIMARY 6379
+OK
+$ $NEW_VALKEY_CLI info | grep '^\(role\|master_host\|master_link_status\)'
+role:slave


what does this statement do?.

Adding comments might help.

content/blog/2025-11-05-valkey-helm-chart/index.md

stockholmux

Fix the author bio then I can review :)

content/blog/2025-11-05-valkey-helm-chart/index.md

Signed-off-by: Silvio Gissi <silvio@gissilabs.com>

stockholmux

Overall good.

A few little issues with shell vs bash, using $, and not commenting example output. In general, this is so if someone copy/pastes via double click everything will actually run in a shell instead of trying to execute the sample output.

stockholmux · 2025-12-01T22:23:41Z

content/blog/2025-11-05-valkey-helm-chart/index.md

+
+### Step 1: Find existing pods, services and namespace
+
+```shell


shell as a tag block causes Zola to spam the following warning: Warning: Highlight language shell not found in blog/2025-11-05-valkey-helm-chart/index.md - it really should be bash (and you'll get syntax highlighting too)

stockholmux · 2025-12-01T22:23:53Z

content/blog/2025-11-05-valkey-helm-chart/index.md

+
+```shell
+# List all pods in all namespaces with app name 'valkey'
+$ kubectl get pods --all-namespaces -l app.kubernetes.io/name=valkey -o custom-columns=Pod:.metadata.name,Namespace:.metadata.namespace,Instance:.metadata.labels.app\\.kubernetes\\.io\\/instance


drop the $

stockholmux · 2025-12-01T22:24:17Z

content/blog/2025-11-05-valkey-helm-chart/index.md

+# List all pods in all namespaces with app name 'valkey'
+$ kubectl get pods --all-namespaces -l app.kubernetes.io/name=valkey -o custom-columns=Pod:.metadata.name,Namespace:.metadata.namespace,Instance:.metadata.labels.app\\.kubernetes\\.io\\/instance
+# * Sample Output *
+Pod                                 Namespace   Instance


comment out all example output (or put it in a different code block).

stockholmux · 2025-12-01T22:24:43Z

content/blog/2025-11-05-valkey-helm-chart/index.md

+
+Install the new Valkey instance:
+
+```shell


shell->bash

stockholmux · 2025-12-01T22:24:52Z

content/blog/2025-11-05-valkey-helm-chart/index.md

+
+Check it is running as expected:
+
+```shell


stockholmux · 2025-12-01T22:25:02Z

content/blog/2025-11-05-valkey-helm-chart/index.md

+
+```shell
+# List new pods and ensure they are in 'Running' state
+$ kubectl get pods -n $NAMESPACE -l app.kubernetes.io/instance=$NEWINSTANCE


stockholmux · 2025-12-01T22:25:12Z

content/blog/2025-11-05-valkey-helm-chart/index.md

+# List new pods and ensure they are in 'Running' state
+$ kubectl get pods -n $NAMESPACE -l app.kubernetes.io/instance=$NEWINSTANCE
+# * Sample Output *
+NAME       READY   STATUS    RESTARTS   AGE


example output should be commented

Signed-off-by: Silvio Gissi <silvio@gissilabs.com>

sgissi · 2025-12-02T04:45:53Z

@mk-raven This is a blog post about migrating from Bitnami's Valkey chart into the official one, feel free to chime in here if you have any comments.

sgissi · 2025-12-02T04:48:22Z

@stockholmux @cherukum-Amazon Post updated. PR valkey-io/valkey-helm#84 needs to be merged and a new chart released before publishing.

cherukum-Amazon

Looks good to me. Thanks Silvio for taking the time.

cherukum-Amazon · 2025-12-01T22:37:33Z

content/blog/2025-11-05-valkey-helm-chart/index.md

+helm repo update
+```
+
+Create a `values.yaml` file that matches your current deployment. The example below is similar to the default Bitnami Valkey configuration:


At the end of the sentence, can we add a link to README/documentation, which authors can reference if they want to configure values.yaml with additional configuration - a) PVC storage for AOF, b) TLS c) Auth d) metrics

Added a commend to refer to the README and chart values.yaml for details. PVC storage is enabled by default but AOF/RDB isn't, I added the control over persistence item in the "What's Next" with a reference to the open issue. Thanks for the review!

stockholmux

Approved with a nit. Fix if you're making another commit, otherwise LGTM.

stockholmux · 2025-12-02T17:06:26Z

content/blog/2025-11-05-valkey-helm-chart/index.md

+# List all pods in all namespaces with app name 'valkey'
+kubectl get pods --all-namespaces -l app.kubernetes.io/name=valkey -o custom-columns=Pod:.metadata.name,Namespace:.metadata.namespace,Instance:.metadata.labels.app\\.kubernetes\\.io\\/instance
+# * Sample Output *
+#Pod                                 Namespace   Instance


Nit: the spacing between the # the sample text is inconsistent. If you make more changes to the post, fix that. I won't hold merge on that though.

Thanks, it looks better indeed with a space in front. Updated now.

stockholmux · 2025-12-02T17:08:01Z

@sgissi Since this is dependent on valkey-io/valkey-helm#84, please swap over to a draft PR. That will prevent accidental merging given that I've already approved the post.

Signed-off-by: Silvio Gissi <silvio@gissilabs.com>

sgissi · 2025-12-02T18:20:35Z

@sgissi Since this is dependent on valkey-io/valkey-helm#84, please swap over to a draft PR. That will prevent accidental merging given that I've already approved the post.

Good point, marked as draft until the PR is merged and the new chart is released.

cherukum-Amazon and others added 2 commits November 18, 2025 22:45

Add blog post: Introduction to Valkey helm chart

411403f

Signed-off-by: cherukum-amazon <cherukum@amazon.com>

Helm Chart Blogpost update

52735ed

Signed-off-by: Silvio Gissi <silvio@gissilabs.com>

sgissi requested review from madolson and stockholmux as code owners November 23, 2025 22:46

cherukum-Amazon reviewed Nov 25, 2025

View reviewed changes

content/blog/2025-11-05-valkey-helm-chart/index.md Outdated Show resolved Hide resolved

stockholmux requested changes Nov 26, 2025

View reviewed changes

content/blog/2025-11-05-valkey-helm-chart/index.md Show resolved Hide resolved

stockholmux mentioned this pull request Nov 26, 2025

Add blog post: Introduction to Valkey helm chart #408

Closed

Update based on feedback

dd84415

Signed-off-by: Silvio Gissi <silvio@gissilabs.com>

stockholmux requested changes Dec 1, 2025

View reviewed changes

Updated shell style and added link to README

297dcf1

Signed-off-by: Silvio Gissi <silvio@gissilabs.com>

cherukum-Amazon approved these changes Dec 2, 2025

View reviewed changes

stockholmux approved these changes Dec 2, 2025

View reviewed changes

Fix sample output spacing and added reference to README and values.yaml

f137dbc

Signed-off-by: Silvio Gissi <silvio@gissilabs.com>

sgissi marked this pull request as draft December 2, 2025 18:19


		### Step 1: Find existing pods, services and namespace

		```shell

Valkey helm #419

Are you sure you want to change the base?

Valkey helm #419

Conversation

sgissi commented Nov 23, 2025

Description

Issues Resolved

Check List

Uh oh!

sgissi commented Nov 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cherukum-Amazon Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cherukum-Amazon Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stockholmux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stockholmux left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sgissi commented Dec 2, 2025

Uh oh!

sgissi commented Dec 2, 2025

Uh oh!

cherukum-Amazon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stockholmux left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stockholmux commented Dec 2, 2025

cherukum-Amazon Nov 25, 2025 •

edited

Loading

cherukum-Amazon Nov 25, 2025 •

edited

Loading