Skip to content

Conversation

@Domainv
Copy link
Contributor

@Domainv Domainv commented Jun 22, 2018

Fixes #3861

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

screenvideo-1

Domainv added 2 commits June 22, 2018 10:01
change parseHours to make 24h as valid value
change setTime to allow changing correct time

Closes [#3861](#3861)
@ghost ghost assigned Domainv Jun 22, 2018
@ghost ghost added the needs review label Jun 22, 2018
@codecov
Copy link

codecov bot commented Jun 22, 2018

Codecov Report

Merging #4454 (d0d781d) into development (6972d53) will increase coverage by 73.79%.
The diff coverage is 72.72%.

Impacted file tree graph

@@               Coverage Diff                @@
##           development    #4454       +/-   ##
================================================
+ Coverage             0   73.79%   +73.79%     
================================================
  Files                0      323      +323     
  Lines                0    11623    +11623     
  Branches             0     2475     +2475     
================================================
+ Hits                 0     8577     +8577     
- Misses               0     1956     +1956     
- Partials             0     1090     +1090     
Impacted Files Coverage Δ
src/timepicker/timepicker.component.ts 92.61% <70.00%> (ø)
src/timepicker/timepicker.utils.ts 97.91% <100.00%> (ø)
src/datepicker/reducer/bs-datepicker.actions.ts 79.10% <0.00%> (ø)
src/chronos/i18n/nl-be.ts 85.71% <0.00%> (ø)
src/chronos/duration/bubble.ts 87.87% <0.00%> (ø)
src/pagination/index.ts 66.66% <0.00%> (ø)
src/datepicker/engine/flag-years-calendar.ts 85.71% <0.00%> (ø)
src/datepicker/yearpicker.component.ts 55.26% <0.00%> (ø)
src/datepicker/models/index.ts 100.00% <0.00%> (ø)
src/datepicker/utils/bs-calendar-utils.ts 84.84% <0.00%> (ø)
... and 315 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6972d53...b7493dc. Read the comment docs.

@valorkin
Copy link
Member

  1. enable AM
  2. enter 23 (will switch to PM and set 11 on Blur) input value==='11'
  3. enter 23 again (onBlur input value==='23')

Can we do some with this?

@Domainv
Copy link
Contributor Author

Domainv commented Jun 25, 2018

lets see

update _renderTime to rewrite value only if do not passed

Closes (#3861)
@Domainv
Copy link
Contributor Author

Domainv commented Jun 26, 2018

added a solution, review required
added new gif

Domainv and others added 7 commits June 26, 2018 18:14
use Renderer2 to access the DOM elements

Closes (#3861)
add Renderer2

Closes (#3861)
remove Renderer2

Closes (#3861)
back Renderer2 for rewrite DOM elements

Closes (#3861)
add/remove tests in timepicker.utils.spec

Closes (#3861)
@valorkin valorkin changed the title Fix timepicker time convertation with meridian fix(timepicker): time convertation with meridian Jul 5, 2018
@daniloff200 daniloff200 requested a review from valorkin February 3, 2020 16:38
@daniloff200
Copy link
Contributor

Project: ngx-bootstrap-demo
Url: https://ngx-bootstrap-demo--pr-4454-wbr2681v.web.app
This link will expire at Sat 27 Feb 2021 12:53:35 PM GMT

@mikolajszymanski
Copy link

Hi guys ;) What is the status of this fix? I have same issue in my project and I don't want to make another PR which will do same thing as in this PR. My opened issue is #6306
@daniloff200 @Domainv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(timepicker): fix time convertation for timepicker with meridian

5 participants