Skip to content

Conversation

@eitamyo
Copy link

@eitamyo eitamyo commented Mar 5, 2020

Fixes #5668
save positioning options per element to prevent overrides

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

Hi! I opened #5668 a couple of weeks ago, and this is my attempt at fixing it.
I noticed the options related to adaptive positioning were saved in a single property in the positioning service here . As a result, every time there were two components open, those options were overridden by the last one. So, my idea was to save the options separately for each component.
Any suggestions are welcome (should I add tests or demos?).

save positioning options per element to prevent
potential overrrides
@eitamyo eitamyo closed this Mar 9, 2020
@eitamyo eitamyo reopened this Mar 9, 2020
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.64%. Comparing base (d785e71) to head (31b7a56).
⚠️ Report is 500 commits behind head on development.

Files with missing lines Patch % Lines
src/tooltip/tooltip.directive.ts 75.00% 1 Missing ⚠️
src/typeahead/typeahead-container.component.ts 0.00% 0 Missing and 1 partial ⚠️
src/typeahead/typeahead.directive.ts 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5706      +/-   ##
===============================================
- Coverage        73.92%   73.64%   -0.29%     
===============================================
  Files              323      323              
  Lines            11641    11639       -2     
  Branches          2477     2480       +3     
===============================================
- Hits              8606     8571      -35     
- Misses            1952     1966      +14     
- Partials          1083     1102      +19     
Files with missing lines Coverage Δ
src/datepicker/bs-datepicker.component.ts 69.84% <100.00%> (ø)
src/datepicker/bs-daterangepicker.component.ts 76.37% <100.00%> (ø)
...ker/themes/bs/bs-datepicker-container.component.ts 75.64% <ø> (-0.31%) ⬇️
...hemes/bs/bs-daterangepicker-container.component.ts 70.65% <ø> (-0.32%) ⬇️
src/popover/popover.directive.ts 73.73% <100.00%> (ø)
src/tooltip/tooltip.directive.ts 67.09% <75.00%> (-0.42%) ⬇️
src/typeahead/typeahead-container.component.ts 74.69% <0.00%> (-0.01%) ⬇️
src/typeahead/typeahead.directive.ts 79.92% <83.33%> (ø)

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d785e71...31b7a56. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tooltip inside popover overrides adaptive positioning

2 participants