This repository was archived by the owner on May 29, 2025. It is now read-only.
Store pkeys in store #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamantios
reviewed
Oct 19, 2023
Adamantios
suggested changes
Oct 19, 2023
Collaborator
Adamantios
left a comment
Adamantios
left a comment
There was a problem hiding this comment.
I fixed the service id issue. Please address this comment:
Adamantios
reviewed
Oct 19, 2023
Adamantios
reviewed
Oct 19, 2023
jmoreira-valory
commented
Oct 19, 2023
| private_key=$(echo -n "$private_key" | | ||
| awk '{ printf substr( $0, '$private_key_start_position', length($0) - '$private_key_start_position' ) }') | ||
|
|
||
| private_key=$(echo -n "$private_key" | awk '{gsub(/\\"/, "\"", $0); print $0}') |
Collaborator
Author
There was a problem hiding this comment.
This is required to replace \" strings to "
(this is required in PR 55, it is irrelevant for non-encrypted keys)
Adamantios
approved these changes
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store pkeys in store permanently, so that there is no need to create temporary files and keep track of deleting them.