Skip to content

benchmark recorder rejects documented chart operation prefixes after successful capture #496

Description

@bmethod

Workflow failure: the canonical record-criterion command completes the ht-chart Criterion suite, then exits 1 and records nothing because parse-criterion rejects the documented chart-shader, chart-state, chart-live, and chart-indicators operation families as unknown. Reproduction: tools/record-criterion -- cargo bench --manifest-path ht-chart/Cargo.toml --bench chart_rendering, on the registered benchmark host under the performance profile. The raw suite succeeds and produces valid measurements; failure occurs only during result classification. This conflicts with the benchmark skill and docs, which prescribe record-criterion and classify chart operations under component ui. Surgical fix: teach the classifier all documented chart prefixes and map them to ui, preferably from one centralized operation-family map; add table-driven coverage for every supported chart prefix plus an unknown-prefix fail-closed case; add an end-to-end fixture proving successful chart output becomes schema-v3 UI records; update skill guidance only if the intended invocation differs. Acceptance: reproduction exits 0 with complete-provenance UI records, unknown prefixes still fail closed, and existing non-chart routing is unchanged. Discovered while executing hyprtrade CC-483 under the required benchmark workflow.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions