Skip to content

fix: harden Windows download filenames and align Tauri npm versions#97

Closed
blueyi wants to merge 2 commits into
vanloctech:mainfrom
blueyi:main
Closed

fix: harden Windows download filenames and align Tauri npm versions#97
blueyi wants to merge 2 commits into
vanloctech:mainfrom
blueyi:main

Conversation

@blueyi

@blueyi blueyi commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Prevent Facebook and other long-title sites from failing with Errno 22 by sanitizing yt-dlp output names, adding configurable filename presets, and pinning https://github.com/tauri-apps packages to match the Rust 2.9 stack.

blueyi and others added 2 commits July 4, 2026 13:01
Prevent Facebook and other long-title sites from failing with Errno 22 by sanitizing yt-dlp output names, adding configurable filename presets, and pinning @tauri-apps packages to match the Rust 2.9 stack.

Co-authored-by: Cursor <cursoragent@cursor.com>
fix: harden Windows download filenames and align Tauri npm versions
@vanloctech

Copy link
Copy Markdown
Owner

Thanks for working on the Windows/long-title filename issue. I agree the underlying problem is real, but I don’t think this PR should be merged as-is.

Youwee already applies --trim-filenames 180, so this PR is not only adding filename limiting. It changes the default output template for all users from %(title)s.%(ext)s to a shortened title plus ID, and also enables ASCII-restricted filenames by default. That changes existing download filenames globally, including normal YouTube downloads and non-English titles, which feels too broad for this fix.

There is also a likely metadata regression: the PR changes the yt-dlp metadata output template to include a truncated title and ID, but the post-processing code still looks for .description and .info.json using a manually sanitized title-only filename. That can make description renaming and comment splitting silently fail.

Could you please narrow this PR to the actual safety fix? A smaller patch that keeps the existing default filename template, improves the existing safe filename args with path-aware trimming / Windows filename handling, and leaves dependency pinning + filename preset UI for separate PRs would be much safer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants