[#82] wire H5CPP_BUILD_TESTS into CI; remove duplicate option#106
Merged
steven-varga merged 2 commits intoMay 8, 2026
Merged
Conversation
release: promote staging docs and gather helpers
- Add -DH5CPP_BUILD_TESTS=ON to the CI configure step so the Test stage actually builds and runs tests (previously ctest found nothing to run) - Remove duplicate option(H5CPP_BUILD_TESTS ...) declaration that appeared twice in CMakeLists.txt Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #82
Summary
Configurestep lacked-DH5CPP_BUILD_TESTS=ON, socmake --buildproduced no test binaries andctestreported "No tests were found!!!" on every run — giving false green badges.option()declaration:option(H5CPP_BUILD_TESTS "Build tests" OFF)appeared twice inCMakeLists.txt(line 15 and ~line 74). The second declaration is a CMake no-op but is misleading; removed.Test plan
cmake -DH5CPP_BUILD_TESTS=ON+ctestpasses 5/5🤖 Generated with Claude Code