Skip to content

[#82] wire H5CPP_BUILD_TESTS into CI; remove duplicate option #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steven-varga merged 2 commits into from
May 8, 2026
Merged

[#82] wire H5CPP_BUILD_TESTS into CI; remove duplicate option #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
058c01b
Merge pull request #104 from vargalabs/staging
steven-varga May 8, 2026
e2b8dfc
[#82]:amelia: wire H5CPP_BUILD_TESTS into CI; remove duplicate option
steven-varga May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ jobs:

- name: Configure
if: env.SKIP_COMPILE == 'false'
run: cmake -B build -DCMAKE_CXX_COMPILER=$CXX -DCMAKE_CXX_STANDARD=23 -DCMAKE_BUILD_TYPE=Release
run: cmake -B build -DCMAKE_CXX_COMPILER=$CXX -DCMAKE_CXX_STANDARD=23 -DCMAKE_BUILD_TYPE=Release -DH5CPP_BUILD_TESTS=ON

- name: Build
if: env.SKIP_COMPILE == 'false'
Expand Down
2 changes: 0 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,6 @@ if(MPI_FOUND AND HDF5_IS_PARALLEL)
message(STATUS "MPI and PHDF5 found: Parallel H5CPP enabled")
endif()

option(H5CPP_BUILD_TESTS "Build tests" OFF)

# Header-only target
add_library(h5cpp INTERFACE)
add_library(h5cpp::h5cpp ALIAS h5cpp)
Expand Down