Skip to content

Making IPFS Client thread-safe. Using cURL Multi API.#57

Merged
melroy89 merged 8 commits intomasterfrom
introducing_multi_api_curl
Jan 7, 2022
Merged

Making IPFS Client thread-safe. Using cURL Multi API.#57
melroy89 merged 8 commits intomasterfrom
introducing_multi_api_curl

Conversation

@melroy89
Copy link
Copy Markdown
Collaborator

@melroy89 melroy89 commented Jan 5, 2022

  • Using LibcURL Multi API
  • Allowing to abort IFPS API calls
  • Fix nlohmann json hpp file (during make install installation)
  • Improved readme/docs
  • Improve doxygen & CI
  • Update go-ipfs binary during testing
  • Upgrade to mac os x 11 (with newer xcode sdk)
  • Adding a C++ multi-threading example!! 👍🏽
  • Threading test-case added as well 🏅

During review, focus on changes to files:

Fixes #54

@melroy89 melroy89 requested a review from vasild January 5, 2022 22:25
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #57 (861db76) into master (8e56921) will decrease coverage by 3.34%.
The diff coverage is 29.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   56.92%   53.58%   -3.35%     
==========================================
  Files           2        2              
  Lines         390      405      +15     
  Branches      186      202      +16     
==========================================
- Hits          222      217       -5     
- Misses          3       11       +8     
- Partials      165      177      +12     
Impacted Files Coverage Δ
src/client.cc 58.18% <25.00%> (-0.13%) ⬇️
src/http/transport-curl.cc 43.84% <30.15%> (-9.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e56921...861db76. Read the comment docs.

@melroy89
Copy link
Copy Markdown
Collaborator Author

melroy89 commented Jan 7, 2022

LGTM! @vasild I will merge when everything is green.

@melroy89 melroy89 merged commit 7a0ac25 into master Jan 7, 2022
@melroy89 melroy89 mentioned this pull request Jan 7, 2022
@melroy89 melroy89 deleted the introducing_multi_api_curl branch February 9, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moving to cURL multi API

2 participants