feat: show absolute line number on the cursor line - #27
Merged
Conversation
In relative mode the gutter showed 0 on the cursor's own line, since its distance from itself is zero. Show its absolute line number there instead, matching vim's hybrid number + relativenumber: relative distances for motions, plus the real line you're on. The gutter already sizes on the buffer's line count, so the wider number fits without reflowing.
The relative-label test still asserted 0 on the cursor's own line, which this branch's change replaced with the line's absolute number. Update the two cursor-line expectations to match the hybrid behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In relative line-number mode the gutter showed
0on the cursor's own line, since its distance from itself is zero. This shows its absolute line number there instead — vim's hybridnumber+relativenumber: relative distances above and below for motions, plus the real line you're on.The change is a single special case in
EditorLineNumberLabel(core/editor/editor.cpp). The gutter already sizes on the buffer's line count, so the wider cursor-line number fits without reflowing the text, and the cursor line keeps its distinctline_number_currentcolor.