gold overflow

[kambala-decapitator]

to reproduce in adequate time: have lots of Ramparts with Treasury

reported in https://forum.vcmi.eu/t/gold-amount-overflow/6091, there's also video demonstrating the bug

Version: 1.3.2

[kambala-decapitator]

it's weird that gold (and probably other resources) are int32 instead of uint64

[IvanSavenko]

Such huge amount would overflow in UI, so not much point.
But yeah, should probably be int64 and have fixed limit - way below int64 max, to avoid overflows, but still high enough to not be reachable

[kambala-decapitator]

we can also apply short form similar to unit count: 10M, 1B etc.

[DjWarmonger]

When I coded it, the total resources counter was 64 bit, but actual gain / loss was limited at 32 bits to prevent this. But, apparanetly it got messed up over all these years.

Let's set it explicitely to 1 billion, that is player can't lose or gain more than 1 billion gold in a single operation.
This is still enough to buy 33333 Azure Dragons.