Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
======================================
Coverage 80.6% 80.6%
======================================
Files 7 7
Lines 464 464
======================================
Hits 374 374
Misses 90 90Continue to review full report at Codecov.
|
Contributor
Author
|
Closing this in favor of #31 |
tony
added a commit
that referenced
this pull request
May 3, 2026
…0.1a13 why: The published `gp_furo_theme-0.0.1a15-py3-none-any.whl` is broken — 28 KB, no `theme/gp-furo/static/` directory, no built CSS or JS. Every consumer of `gp-sphinx==0.0.1a15` therefore renders an unstyled docs site (e.g. https://libtmux.git-pull.com/, https://gp-sphinx.git-pull.com/). Two failures chained in the v0.0.1a15 release: 1. `release.yml` ran `uv build` without first running `pnpm exec vite build`, so the gitignored `static/` tree was empty when hatchling packed the wheel. 2. Even if vite had run, `static/` is gitignored — without `[tool.hatch.build.targets.{sdist,wheel}.force-include]`, hatchling's default gitignore-aware file selection would still have dropped it. A force-include + CI ordering fix is in flight on `git-pull/gp-sphinx` (#27, branch `loud-fail-missing-assets`), but it introduced a fresh regression: editable installs via `uv sync` now fail with `FileNotFoundError: Forced include not found` when the static dir doesn't exist on disk. The packaging design needs more work before a16 can ship. In the meantime, pinning every consumer back to a13 (the last version that produced a working wheel — see https://pypi.org/project/gp-sphinx/0.0.1a13/) unblocks docs builds across all 14 downstream sites. We chose a13 rather than a14 because a14 was also part of the broken release wave (same packaging architecture, same risk surface). what: - pyproject.toml: revert `gp-sphinx`, `sphinx-autodoc-api-style`, `sphinx-autodoc-pytest-fixtures` pins from `==0.0.1a15` back to `==0.0.1a13` in `[dependency-groups] dev` and `docs`. - uv.lock: regenerated against the a13 pins; gp-sphinx workspace siblings (sphinx-gp-theme, sphinx-ux-autodoc-layout, sphinx-ux-badges, sphinx-fonts, sphinx-autodoc-typehints-gp, …) co-resolved back to 0.0.1a13. The upstream `furo==2025.12.19` dependency reappears as a transitive (gp-sphinx 0.0.1a13 still consumed it; a15 replaced it with the in-tree `gp-furo-theme`). ref: https://pypi.org/project/gp-sphinx/0.0.1a13/ ref: git-pull/gp-sphinx#27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a new version of sphinx available.
You are currently using 1.5.6. I have updated it to 1.6.1
These links might come in handy: PyPI | Changelog | Homepage
Changelog
Got merge conflicts? Close this PR and delete the branch. I'll create a new PR for you.
Happy merging! 🤖