Skip to content

chore(git): Remove uses_netloc for git+ssh, already in cpython #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tony merged 2 commits into from
Jun 25, 2022
Merged

chore(git): Remove uses_netloc for git+ssh, already in cpython #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf886bb
chore(git): Remove uses_netloc for git+ssh, already in cpython
tony Jun 25, 2022
2db34ea
docs(CHANGES): Note removal of redundant netloc
tony Jun 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CHANGES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,18 @@ $ pip install --user --upgrade --pre libvcs

_Backport from 0.13.3_

### Cleanup

- :{issue}`378` Remove duplicate `uses_netloc` scheme for `git+ssh` (this was in cpython since 2.7 /
3.1 [^git+ssh][^python:bugs:8657])

[^git+ssh]: [python/cpython@ead169d]

[python/cpython@ead169d]:
https://github.com/python/cpython/commit/ead169d3114ed0f1041b5b59ca20293449608c50

[^python:bugs:8657]: <https://bugs.python.org/issue8657>

## libvcs 0.13.6 (2022-06-18)

### Development
Expand Down
2 changes: 1 addition & 1 deletion libvcs/projects/git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def convert_pip_url(pip_url: str) -> VCSLocation:

class GitProject(BaseProject):
bin_name = "git"
schemes = ("git", "git+http", "git+https", "git+ssh", "git+git", "git+file")
schemes = ("git", "git+http", "git+https", "git+git", "git+file")
_remotes: GitProjectRemoteDict

def __init__(
Expand Down