Fix gitconfig fixture to always write config (Take 4 for #509) #512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
gitconfigfixture to always write config - removes early return that skipped writing when file existsfile://protocol in test fixture #510, Fixgit_repofixture for submodulefile://protocol #511 for test failure against python 3.14 #509Problem
The
gitconfigfixture had an early return at lines 157-158:If ANYTHING creates
.gitconfigfirst (empty or incomplete) - git itself duringgit init, the nspawn container setup, another fixture - the fixture returns early WITHOUT writingprotocol.file.allow=always.Confirmed by reporter running debug script: empty
.gitconfigwas created by container/git before the fixture could write the proper config.Solution
Remove the early return. The fixture now always writes the complete config with
protocol.file.allow=always.Test plan
test_git_repo_fixture_submodule_file_protocolpasses