-
Notifications
You must be signed in to change notification settings - Fork 14
Fixes for discover
#487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fixes for discover
#487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #487 +/- ##
==========================================
+ Coverage 77.95% 78.52% +0.56%
==========================================
Files 14 14
Lines 1901 1937 +36
Branches 401 404 +3
==========================================
+ Hits 1482 1521 +39
+ Misses 272 271 -1
+ Partials 147 145 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tony
added a commit
that referenced
this pull request
Nov 15, 2025
tony
added a commit
that referenced
this pull request
Nov 15, 2025
tony
added a commit
that referenced
this pull request
Nov 15, 2025
014ddd1 to
33f770a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Bug Fixes
vcspull discover: Success logs redact config pathsWrites triggered by
vcspull discovernow pass the config file throughPrivatePath, so confirmations like "✓ Successfully updated ~/.vcspull.yaml"and dry-run notices no longer leak the absolute home directory.
vcspull discover: Fix another workspace dir caseDiscover now inspects the config scope (user/system/project) before writing,
so user-level configs like
~/.vcspull.yamlprefer tilde-prefixed workspacekeys while project-level configs keep their relative
./sections. Testscover both behaviors to guard against regressions.