Skip to content

feat(expression): adds expressions#468

Merged
2xAA merged 6 commits intomainfrom
feat/expression
Dec 1, 2020
Merged

feat(expression): adds expressions#468
2xAA merged 6 commits intomainfrom
feat/expression

Conversation

@2xAA
Copy link
Copy Markdown
Member

@2xAA 2xAA commented Nov 28, 2020

Adds the expression editor from modV 2

fix #453 fix #415

@2xAA
feat(expression): adds expressions
d781a8a 
Adds the expression editor from modV 2

fix #453 fix #415
@2xAA 2xAA requested a review from TimPietrusky November 28, 2020 23:52
@2xAA
Copy link
Copy Markdown
Member Author

2xAA commented Nov 28, 2020

Requires preset saving functionality and docs on modv.vcync.gl to be added before merge.

@2xAA
Copy link
Copy Markdown
Member Author

2xAA commented Nov 30, 2020

Expressions docs PR here: vcync/modv.vcync.gl#24

@2xAA 2xAA marked this pull request as ready for review November 30, 2020 00:46
@TimPietrusky
Copy link
Copy Markdown
Member

TimPietrusky commented Dec 1, 2020

@2xAA I tested it and it works great.

I would prefer if the textarea would be bigger, can I make the changes? I found the code for this, but not sure if you want that or not.

@2xAA
Copy link
Copy Markdown
Member Author

2xAA commented Dec 1, 2020

@TimPietrusky sure! Implement away 😅

@TimPietrusky
Copy link
Copy Markdown
Member

TimPietrusky commented Dec 1, 2020

@2xAA so if you agree with my change that makes the textarea fill up the whole space in width, we can merge this!

@TimPietrusky
Copy link
Copy Markdown
Member

TimPietrusky commented Dec 1, 2020

@2xAA also vcync/modv.vcync.gl#24 (review) was merged and we just need to create a new version.

@2xAA
Copy link
Copy Markdown
Member Author

2xAA commented Dec 1, 2020

@TimPietrusky I just reduced the cell size slightly so it's in line with Tween above. You still have double the room.

Thanks for reviewing the docs!

@2xAA 2xAA merged commit ab13872 into main Dec 1, 2020
@2xAA 2xAA deleted the feat/expression branch December 1, 2020 23:05
2xAA pushed a commit that referenced this pull request Dec 1, 2020
@semantic-release-bot
chore(release): 3.5.0
9d2c397 
# [3.5.0](3.4.0...3.5.0) (2020-12-01)

### Features

* **expression:** adds expressions ([#468](#468)) ([ab13872](ab13872)), closes [#453](#453) [#415](#415)
@2xAA
Copy link
Copy Markdown
Member Author

2xAA commented Dec 1, 2020

🎉 This PR is included in version 3.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@2xAA 2xAA added the released label Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimPietrusky TimPietrusky Awaiting requested review from TimPietrusky

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Audio Feature]: min / max value Input Breakpoints to change a property value for different thresholds

2 participants

@2xAA @TimPietrusky