fix: module hot reload (#755)#786
Merged
TimPietrusky merged 1 commit intomainfrom Nov 8, 2022
Merged
Conversation
* fix: update active module props on hot reload * fix: loading preset when module has had a property added after the preset was saved * fix: fixes initialisation of module props inputs * fix(hot-reloading): added some stuff to make it work even better * fix(hot-reloading): moved some stuff around so that the inputs are loaded correctly * refactor: use i for iterator * fix: remove console.log * fix: add writeToSwap argument for module initialisation * fix: update range control when min/max parameters change * fix: use default value for complex data types * fix: fallback to default value for undefined complex data types Co-authored-by: Tim Pietrusky <timpietrusky@gmail.com>
Member
|
🎉 This PR is included in version 3.25.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: update active module props on hot reload
fix: loading preset when module has had a property added after the preset was saved
fix: fixes initialisation of module props inputs
fix(hot-reloading): added some stuff to make it work even better
fix(hot-reloading): moved some stuff around so that the inputs are loaded correctly
refactor: use i for iterator
fix: remove console.log
fix: add writeToSwap argument for module initialisation
fix: update range control when min/max parameters change
fix: use default value for complex data types
fix: fallback to default value for undefined complex data types
Co-authored-by: Tim Pietrusky timpietrusky@gmail.com