feat: audio input gain control#800
Conversation
|
…le to properly display value to UI
| switchingAudio: false, | ||
| switchingVideo: false | ||
| switchingVideo: false, | ||
| gainRangeValue: 1 |
There was a problem hiding this comment.
Using a value on data so we can keep track of what the value is doing.
Vue wasn't aware of the value before this.
We also update the value when the component is created below in the created function.
|
@TimPietrusky If you're happy with this PR, we can merge! |
|
I will not merge this yet, as it's "hard" to get back to 1 or any specific value, as we can't use a right click on the slider as with the other slider we have. I will use the branch for my gig, but we should refactor this so that it's also possible to set the value via input field. Also the tooltip of the range-slider and the value shown on the right are not the same in some cases, which is misleading. |
|
@TimPietrusky Ready to review again. This should have addressed your comments |
# [3.26.0](3.25.5...3.26.0) (2023-03-01) ### Bug Fixes * **checkbox:** add boolean emission prop ([#792](#792)) ([e62f47a](e62f47a)) * **color-picker:** dismiss color picker by clicking outside color picker ([#793](#793)) ([015b84a](015b84a)), closes [#461](#461) * **plugins:** emit boolean from checkbox ([#795](#795)) ([c13f54a](c13f54a)) * **styling:** fix unwanted top range control alignment in module inspector ([#806](#806)) ([0082450](0082450)) * **styling:** update tab styles to match design. fix tab dropdown stacking ([#815](#815)) ([a280099](a280099)) * **swap:** properly set default swap structure when finished swapping ([#766](#766)) ([144453c](144453c)), closes [#765](#765) ### Features * add animated loader, remove when loaded to prevent redraws ([#771](#771)) ([57f3658](57f3658)) * add automation of browserslist update ([#787](#787)) ([16f33a6](16f33a6)), closes [#691](#691) * audio input gain control ([#800](#800)) ([07ac0a0](07ac0a0)) * **gallery-item:** implement better gallery item scaling ([#791](#791)) ([9146c1e](9146c1e))
|
🎉 This PR is included in version 3.26.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 participants
See #727