fix: conform path paths for crossplatform compatibility#835
Merged
TimPietrusky merged 1 commit intonextfrom Apr 1, 2023
Merged
fix: conform path paths for crossplatform compatibility#835TimPietrusky merged 1 commit intonextfrom
TimPietrusky merged 1 commit intonextfrom
Conversation
Member
|
@2xAA for real? The path separator? 🙈 Thanks for the fix! |
Member
Author
|
This is just for loading the textures, I don’t think it fixes what we saw
on Thursday.
I haven’t been able to test with my MacBook again yet.
…On Sat, 1 Apr 2023 at 11:36, NERDDISCO ***@***.***> wrote:
@2xAA <https://github.com/2xAA> for real? The path separator? 🙈
Super strange that we have never encountered this so far.
—
Reply to this email directly, view it on GitHub
<#835 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEHJ23TAL6AUH7T65NIPCTW7AALLANCNFSM6AAAAAAWOYLJ3A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
Oh I see, thanks! |
|
🎉 This PR is included in version 3.27.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes bad import for uuid in video.js.