Update dependencies, C++ standard, and improve Dockerfiles for better build and localization #2549
Conversation
WalkthroughWalkthroughThe recent updates significantly enhance functionality and maintainability across the codebase. Key improvements include optimized Dockerfile configurations for better locale and timezone handling, upgrades to Go module dependencies for improved performance and security, and enhancements to the Makefile for more efficient builds of C++ libraries. Additionally, tool versions such as Rust and CMake have been standardized, fostering consistent development environments and streamlining CI/CD workflows. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant CI
Developer->>CI: Trigger CI Workflow
CI->>CI: Build Docker Images
CI->>CI: Run Tests and Linting
CI->>CI: Deploy Applications
CI->>Developer: Workflow Complete
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
[CHATOPS:HELP] ChatOps commands.
|
|
[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/dependency%2Fupdate%2Fgo-modules/8cd55191dd96b29a6459707643b15e994fef2ef4 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (4)
- Makefile (1 hunks)
- go.mod (8 hunks)
- hack/docker/gen/main.go (1 hunks)
- hack/go.mod.default (1 hunks)
Files skipped from review due to trivial changes (2)
- hack/docker/gen/main.go
- hack/go.mod.default
Additional comments not posted (16)
Makefile (1)
142-142: LGTM! Ensure compatibility with C++23.The
LDFLAGSupdate to usegnu++23is approved. Verify that the rest of the codebase is compatible with C++23 to avoid potential issues during compilation.go.mod (15)
18-18: Dependency Update:code.cloudfoundry.org/bytefmtUpdated to
v0.0.0-20240726181224-f9b67668c814. Ensure functionality is verified with the new version.
195-195: Dependency Update:github.com/klauspost/compressUpdated to
v1.17.10-0.20240726110848-d76f801616d1. Ensure functionality is verified with the new version.
228-228: Dependency Update:github.com/onsi/ginkgo/v2Updated to
v2.19.1. Ensure functionality is verified with the new version.
332-332: Dependency Update:k8s.io/apiUpdated to
v0.30.3. Ensure functionality is verified with the new version.
333-333: Dependency Update:k8s.io/apiextensions-apiserverUpdated to
v0.30.3. Ensure functionality is verified with the new version.
334-334: Dependency Update:k8s.io/apimachineryUpdated to
v0.30.3. Ensure functionality is verified with the new version.
335-335: Dependency Update:k8s.io/cli-runtimeUpdated to
v0.30.3. Ensure functionality is verified with the new version.
336-336: Dependency Update:k8s.io/client-goUpdated to
v0.30.3. Ensure functionality is verified with the new version.
337-337: Dependency Update:k8s.io/component-baseUpdated to
v0.30.3. Ensure functionality is verified with the new version.
339-339: Dependency Update:k8s.io/kube-openapiUpdated to
v0.0.0-20240726031636-6f6746feab9c. Ensure functionality is verified with the new version.
340-340: Dependency Update:k8s.io/kubernetesUpdated to
v0.30.3. Ensure functionality is verified with the new version.
341-341: Dependency Update:k8s.io/metricsUpdated to
v0.30.3. Ensure functionality is verified with the new version.
420-420: Dependency Update:sigs.k8s.io/yamlUpdated to
v1.4.0. Ensure functionality is verified with the new version.
440-440: Dependency Update:github.com/emicklei/go-restful/v3Updated to
v3.12.1. Ensure functionality is verified with the new version.
521-521: Dependency Update:k8s.io/klog/v2Updated to
v2.130.1. Ensure functionality is verified with the new version.
Profile Report
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (4)
- Makefile (1 hunks)
- go.mod (8 hunks)
- hack/docker/gen/main.go (1 hunks)
- hack/go.mod.default (1 hunks)
Files skipped from review due to trivial changes (2)
- go.mod
- hack/docker/gen/main.go
Additional comments not posted (8)
hack/go.mod.default (7)
332-332: Verify the compatibility of the updated dependency.Ensure that the new version
k8s.io/api v0.30.3is compatible with the project's requirements and does not introduce breaking changes.
333-333: Verify the compatibility of the updated dependency.Ensure that the new version
k8s.io/apiextensions-apiserver v0.30.3is compatible with the project's requirements and does not introduce breaking changes.
334-334: Verify the compatibility of the updated dependency.Ensure that the new version
k8s.io/apimachinery v0.30.3is compatible with the project's requirements and does not introduce breaking changes.
335-335: Verify the compatibility of the updated dependency.Ensure that the new version
k8s.io/cli-runtime v0.30.3is compatible with the project's requirements and does not introduce breaking changes.
336-336: Verify the compatibility of the updated dependency.Ensure that the new version
k8s.io/client-go v0.30.3is compatible with the project's requirements and does not introduce breaking changes.
337-337: Verify the compatibility of the updated dependency.Ensure that the new version
k8s.io/component-base v0.30.3is compatible with the project's requirements and does not introduce breaking changes.
340-340: Verify the compatibility of the updated dependency.Ensure that the new version
k8s.io/kubernetes v0.30.3is compatible with the project's requirements and does not introduce breaking changes.Makefile (1)
142-142: Verify the compatibility of the updated C++ standard version.Ensure that the new C++ standard version
gnu++23is compatible with the project's requirements and does not introduce breaking changes.
kpango
force-pushed
the
dependency/update/go-modules
branch
from
3b20970
to
dc26a32
Compare
Deploying vald with
|
| Latest commit: |
74d9cbf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://85e44fdc.vald.pages.dev |
| Branch Preview URL: | https://dependency-update-go-modules.vald.pages.dev |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (8)
- .github/workflows/e2e-chaos.yaml (4 hunks)
- .github/workflows/e2e-max-dim.yml (1 hunks)
- .github/workflows/e2e-profiling.yml (1 hunks)
- .github/workflows/e2e.yml (8 hunks)
- Makefile (1 hunks)
- go.mod (8 hunks)
- hack/docker/gen/main.go (1 hunks)
- hack/go.mod.default (1 hunks)
Files skipped from review due to trivial changes (1)
- Makefile
Files skipped from review as they are similar to previous changes (3)
- go.mod
- hack/docker/gen/main.go
- hack/go.mod.default
Additional comments not posted (24)
.github/workflows/e2e-max-dim.yml (3)
35-36: Addition ofdetect-ci-containerjob looks good.The new job
detect-ci-containeris correctly added to the workflow.
39-39: Modification toe2e-max-dimension-insertjob dependency looks good.The job
e2e-max-dimension-insertnow correctly depends ondetect-ci-container.
42-43: Dynamic container image specification looks good.The job
e2e-max-dimension-insertnow uses a dynamically set container image based on the output ofdetect-ci-container.However, ensure that the
detect-ci-containerjob correctly outputs theTAG..github/workflows/e2e-profiling.yml (3)
36-37: Addition ofdetect-ci-containerjob looks good.The new job
detect-ci-containeris correctly added to the workflow.
40-40: Modification toe2e-profilingjob dependency looks good.The job
e2e-profilingnow correctly depends ondetect-ci-container.
43-44: Dynamic container image specification looks good.The job
e2e-profilingnow uses a dynamically set container image based on the output ofdetect-ci-container.However, ensure that the
detect-ci-containerjob correctly outputs theTAG.Verification successful
The
TAGoutput is correctly set and used in thedetect-ci-containerjob.
- The
TAGoutput is defined in thedetect-ci-containerjob.- The
determine-docker-image-tagaction correctly sets theTAGbased on the GitHub reference.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the output of the `detect-ci-container` job. # Test: Search for the output `TAG` in the `detect-ci-container` job. Expect: Output `TAG` is correctly set. rg --type yaml 'outputs:\s*TAG:' .github/workflows/_detect-ci-container.ymlLength of output: 77
Script:
#!/bin/bash # Description: Verify the outputs of the `detect-ci-container` job. # Test: Search for all outputs in the `detect-ci-container` job. Expect: Outputs are correctly set. rg --type yaml 'outputs:' -A 5 .github/workflows/_detect-ci-container.ymlLength of output: 419
Script:
#!/bin/bash # Description: Verify the definitions of `jobs.detect.outputs.TAG` and `steps.get_tag_name.outputs.TAG` in the `detect-ci-container` job. # Test: Search for the definitions of `jobs.detect.outputs.TAG` and `steps.get_tag_name.outputs.TAG`. Expect: Definitions are correctly set. rg --type yaml 'jobs.detect.outputs.TAG' -A 5 .github/workflows/_detect-ci-container.yml rg --type yaml 'steps.get_tag_name.outputs.TAG' -A 5 .github/workflows/_detect-ci-container.ymlLength of output: 543
Script:
#!/bin/bash # Description: Verify the implementation of the `determine-docker-image-tag` action. # Test: Search for the implementation of the `determine-docker-image-tag` action. Expect: The action correctly sets the `TAG` output. rg --type yaml 'id: determine_tag_name' -A 10 .github/actions/determine-docker-image-tagLength of output: 1431
.github/workflows/e2e-chaos.yaml (9)
38-39: Addition ofdetect-ci-containerjob looks good.The new job
detect-ci-containeris correctly added to the workflow.
42-42: Modification toagent-failurejob dependency looks good.The job
agent-failurenow correctly depends ondetect-ci-container.
82-82: Modification torandom-pod-failurejob dependency looks good.The job
random-pod-failurenow correctly depends ondetect-ci-container.
122-122: Modification toagent-network-partitionjob dependency looks good.The job
agent-network-partitionnow correctly depends ondetect-ci-container.
162-162: Modification toclusterwide-network-bandwidthjob dependency looks good.The job
clusterwide-network-bandwidthnow correctly depends ondetect-ci-container.
125-126: Dynamic container image specification looks good.The job
agent-network-partitionnow uses a dynamically set container image based on the output ofdetect-ci-container.However, ensure that the
detect-ci-containerjob correctly outputs theTAG.Verification successful
The
TAGoutput in thedetect-ci-containerjob is correctly defined and set.
- The
detect-ci-containerjob in.github/workflows/_detect-ci-container.ymlcorrectly outputs theTAGvalue as expected.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the output of the `detect-ci-container` job. # Test: Search for the output `TAG` in the `detect-ci-container` job. Expect: Output `TAG` is correctly set. rg --type yaml 'outputs:\s*TAG:' .github/workflows/_detect-ci-container.ymlLength of output: 77
Script:
#!/bin/bash # Description: Verify the output of the `detect-ci-container` job. # Test 1: Search for the output `TAG` in the `detect-ci-container` job. rg 'outputs:\s*TAG:' .github/workflows/_detect-ci-container.yml # Test 2: Display the content of the file to manually inspect if necessary. cat .github/workflows/_detect-ci-container.ymlLength of output: 1794
165-166: Dynamic container image specification looks good.The job
clusterwide-network-bandwidthnow uses a dynamically set container image based on the output ofdetect-ci-container.However, ensure that the
detect-ci-containerjob correctly outputs theTAG.Verification successful
The
detect-ci-containerjob correctly outputs theTAG.The
detect-ci-containerjob in the.github/workflows/_detect-ci-container.ymlfile includes an outputTAGwhich is correctly set by theget_tag_namestep.
- The
outputs: TAGis defined underworkflow_call.- The
jobs.detect.outputs.TAGis set by theget_tag_namestep.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the output of the `detect-ci-container` job. # Test: Search for the output `TAG` in the `detect-ci-container` job. Expect: Output `TAG` is correctly set. rg --type yaml 'outputs:\s*TAG:' .github/workflows/_detect-ci-container.ymlLength of output: 77
Script:
#!/bin/bash # Check if the file .github/workflows/_detect-ci-container.yml exists if [ -f .github/workflows/_detect-ci-container.yml ]; then # If the file exists, search for the output `TAG` in the `detect-ci-container` job rg --type yaml 'outputs:\s*TAG:' .github/workflows/_detect-ci-container.yml else echo "File .github/workflows/_detect-ci-container.yml does not exist." fiLength of output: 133
Script:
#!/bin/bash # Output the entire content of the .github/workflows/_detect-ci-container.yml file cat .github/workflows/_detect-ci-container.ymlLength of output: 1728
45-46: Dynamic container image specification looks good.The job
agent-failurenow uses a dynamically set container image based on the output ofdetect-ci-container.However, ensure that the
detect-ci-containerjob correctly outputs theTAG.Verification successful
The
TAGoutput is correctly defined in the_detect-ci-container.ymlfile.The
TAGoutput is specified with the description "The docker image tag name" and its value is set from thedetectjob's output.
.github/workflows/_detect-ci-container.ymloutputs: TAG: description: "The docker image tag name" value: ${{ jobs.detect.outputs.TAG }}Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the output of the `detect-ci-container` job. # Test: Search for the output `TAG` in the `detect-ci-container` job. Expect: Output `TAG` is correctly set. rg --type yaml 'outputs:\s*TAG:' .github/workflows/_detect-ci-container.ymlLength of output: 77
Script:
#!/bin/bash # Description: Verify the presence of the `_detect-ci-container.yml` file and search for the `outputs` section. # Step 1: List the contents of the `.github/workflows` directory. echo "Listing contents of .github/workflows directory:" ls .github/workflows # Step 2: Search for the `outputs` section in the `_detect-ci-container.yml` file. echo "Searching for 'outputs' section in _detect-ci-container.yml file:" rg --type yaml 'outputs:' .github/workflows/_detect-ci-container.ymlLength of output: 1717
Script:
#!/bin/bash # Description: Verify the `TAG` output in the `_detect-ci-container.yml` file. # Step 1: Search for the `TAG` output in the `outputs` section of the `_detect-ci-container.yml` file. echo "Searching for 'TAG' output in the 'outputs' section of _detect-ci-container.yml file:" rg --type yaml 'outputs:\s*TAG:' .github/workflows/_detect-ci-container.yml -A 5Length of output: 275
Script:
#!/bin/bash # Description: List all outputs defined in the `_detect-ci-container.yml` file. # Step 1: Search for all outputs in the `_detect-ci-container.yml` file. echo "Listing all outputs in the _detect-ci-container.yml file:" rg --type yaml 'outputs:' .github/workflows/_detect-ci-container.yml -A 10Length of output: 781
85-86: Dynamic container image specification looks good.The job
random-pod-failurenow uses a dynamically set container image based on the output ofdetect-ci-container.However, ensure that the
detect-ci-containerjob correctly outputs theTAG.Verification successful
The
detect-ci-containerjob correctly outputs theTAG.The
get_tag_namestep in thedetect-ci-containerjob extracts theTAGfrom theTAGSenvironment variable and sets it in the GitHub output as expected.
.github/workflows/_detect-ci-container.yml
stepssectionget_tag_namestepScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the output of the `detect-ci-container` job. # Test: Search for the output `TAG` in the `detect-ci-container` job. Expect: Output `TAG` is correctly set. rg --type yaml 'outputs:\s*TAG:' .github/workflows/_detect-ci-container.ymlLength of output: 77
Script:
#!/bin/bash # Description: Verify the output of the `detect-ci-container` job. # Test 1: Search for the `outputs` section in the `detect-ci-container` job file. rg --type yaml 'outputs:' .github/workflows/_detect-ci-container.yml # Test 2: Search for the `TAG` definition within the `outputs` section. rg --type yaml 'TAG:' .github/workflows/_detect-ci-container.ymlLength of output: 219
Script:
#!/bin/bash # Description: Verify the `get_tag_name` step and its `outputs.TAG` definition in the `detect-ci-container` job. # Test 1: Search for the `get_tag_name` step definition. rg --type yaml 'get_tag_name:' .github/workflows/_detect-ci-container.yml -A 10 # Test 2: Search for the `outputs.TAG` definition within the `get_tag_name` step. rg --type yaml 'outputs:\s*TAG:' .github/workflows/_detect-ci-container.yml -A 5Length of output: 162
Script:
#!/bin/bash # Description: Verify the `get_tag_name` step and its `outputs.TAG` definition in the `detect-ci-container` job. # Test 1: Search for the `steps` section in the `detect-ci-container` job file. rg --type yaml 'steps:' .github/workflows/_detect-ci-container.yml -A 20 # Test 2: Search for the `get_tag_name` step definition within the `steps` section. rg --type yaml 'get_tag_name:' .github/workflows/_detect-ci-container.yml -A 10Length of output: 891
.github/workflows/e2e.yml (9)
36-37: LGTM!The addition of the
detect-ci-containerjob looks good and is consistent with the workflow requirements.
40-44: LGTM!The changes to the
e2e-stream-crudjob, including the dependency update todetect-ci-containerand the addition of the container section, look good and are consistent with the workflow requirements.
80-84: LGTM!The changes to the
e2e-stream-crud-for-operatorjob, including the dependency update todetect-ci-containerand the addition of the container section, look good and are consistent with the workflow requirements.
142-146: LGTM!The changes to the
e2e-stream-crud-under-index-management-jobsjob, including the dependency update todetect-ci-containerand the addition of the container section, look good and are consistent with the workflow requirements.
186-190: LGTM!The changes to the
e2e-stream-crud-skip-exist-checkjob, including the dependency update todetect-ci-containerand the addition of the container section, look good and are consistent with the workflow requirements.
226-230: LGTM!The changes to the
e2e-multiapis-crudjob, including the dependency update todetect-ci-containerand the addition of the container section, look good and are consistent with the workflow requirements.
262-266: LGTM!The changes to the
e2e-jobsjob, including the dependency update todetect-ci-containerand the addition of the container section, look good and are consistent with the workflow requirements.
295-299: LGTM!The changes to the
e2e-stream-crud-with-readreplicajob, including the dependency update todetect-ci-containerand the addition of the container section, look good and are consistent with the workflow requirements.
345-349: LGTM!The changes to the
e2e-stream-crud-with-mirrorjob, including the dependency update todetect-ci-containerand the addition of the container section, look good and are consistent with the workflow requirements.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (8)
- .github/workflows/e2e-chaos.yaml (4 hunks)
- .github/workflows/e2e-max-dim.yml (1 hunks)
- .github/workflows/e2e-profiling.yml (1 hunks)
- .github/workflows/e2e.yml (8 hunks)
- Makefile (1 hunks)
- go.mod (8 hunks)
- hack/docker/gen/main.go (1 hunks)
- hack/go.mod.default (1 hunks)
Files skipped from review due to trivial changes (1)
- Makefile
Files skipped from review as they are similar to previous changes (3)
- go.mod
- hack/docker/gen/main.go
- hack/go.mod.default
Additional comments not posted (20)
.github/workflows/e2e-max-dim.yml (3)
35-36: New jobdetect-ci-containeradded.The new job
detect-ci-containeris correctly added to the workflow.
39-43: Jobe2e-max-dimension-insertupdated.The job
e2e-max-dimension-insertnow depends ondetect-ci-containerand uses its output for the container image. This improves the modularity and control flow of the workflow.
42-43: Container configuration added to jobe2e-max-dimension-insert.The job
e2e-max-dimension-insertnow includes a container configuration that pulls an image from the GitHub Container Registry. This ensures that the job runs in a specific environment, improving reliability..github/workflows/e2e-profiling.yml (3)
36-37: New jobdetect-ci-containeradded.The new job
detect-ci-containeris correctly added to the workflow.
40-44: Jobe2e-profilingupdated.The job
e2e-profilingnow depends ondetect-ci-containerand uses its output for the container image. This improves the modularity and control flow of the workflow.
43-44: Container configuration added to jobe2e-profiling.The job
e2e-profilingnow includes a container configuration that pulls an image from the GitHub Container Registry. This ensures that the job runs in a specific environment, improving reliability..github/workflows/e2e-chaos.yaml (5)
38-39: New jobdetect-ci-containeradded.The new job
detect-ci-containeris correctly added to the workflow.
42-46: Jobagent-failureupdated.The job
agent-failurenow depends ondetect-ci-containerand uses its output for the container image. This improves the modularity and control flow of the workflow.
82-86: Jobrandom-pod-failureupdated.The job
random-pod-failurenow depends ondetect-ci-containerand uses its output for the container image. This improves the modularity and control flow of the workflow.
122-126: Jobagent-network-partitionupdated.The job
agent-network-partitionnow depends ondetect-ci-containerand uses its output for the container image. This improves the modularity and control flow of the workflow.
162-166: Jobclusterwide-network-bandwidthupdated.The job
clusterwide-network-bandwidthnow depends ondetect-ci-containerand uses its output for the container image. This improves the modularity and control flow of the workflow..github/workflows/e2e.yml (9)
36-37: LGTM! The new jobdetect-ci-containeris correctly defined.The addition of the
detect-ci-containerjob enhances the workflow by dynamically detecting the CI container.
40-44: LGTM! The jobe2e-stream-crudis correctly updated.The dependency on
detect-ci-containerand the addition of thecontainerspecification enhance the consistency and reproducibility of the job.
80-84: LGTM! The jobe2e-stream-crud-for-operatoris correctly updated.The dependency on
detect-ci-containerand the addition of thecontainerspecification enhance the consistency and reproducibility of the job.
142-146: LGTM! The jobe2e-stream-crud-under-index-management-jobsis correctly updated.The dependency on
detect-ci-containerand the addition of thecontainerspecification enhance the consistency and reproducibility of the job.
186-190: LGTM! The jobe2e-stream-crud-skip-exist-checkis correctly updated.The dependency on
detect-ci-containerand the addition of thecontainerspecification enhance the consistency and reproducibility of the job.
226-230: LGTM! The jobe2e-multiapis-crudis correctly updated.The dependency on
detect-ci-containerand the addition of thecontainerspecification enhance the consistency and reproducibility of the job.
262-266: LGTM! The jobe2e-jobsis correctly updated.The dependency on
detect-ci-containerand the addition of thecontainerspecification enhance the consistency and reproducibility of the job.
295-299: LGTM! The jobe2e-stream-crud-with-readreplicais correctly updated.The dependency on
detect-ci-containerand the addition of thecontainerspecification enhance the consistency and reproducibility of the job.
345-349: LGTM! The jobe2e-stream-crud-with-mirroris correctly updated.The dependency on
detect-ci-containerand the addition of thecontainerspecification enhance the consistency and reproducibility of the job.
kpango
force-pushed
the
dependency/update/go-modules
branch
from
f90d0a3
to
c2e7383
Compare
… build systems and localization Signed-off-by: kpango <kpango@vdaas.org>
kpango
force-pushed
the
dependency/update/go-modules
branch
from
c2e7383
to
74d9cbf
Compare
There was a problem hiding this comment.
Caution
Inline review comments failed to post
Actionable comments posted: 7
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (3)
example/client/go.sumis excluded by!**/*.sumgo.sumis excluded by!**/*.sumrust/Cargo.lockis excluded by!**/*.lock
Files selected for processing (57)
- .gitfiles (6 hunks)
- .github/ISSUE_TEMPLATE/bug_report.md (1 hunks)
- .github/ISSUE_TEMPLATE/security_issue_report.md (1 hunks)
- .github/PULL_REQUEST_TEMPLATE.md (1 hunks)
- .github/actions/setup-e2e/action.yaml (2 hunks)
- .github/actions/setup-k3d/action.yaml (2 hunks)
- .github/helm/values/values-chaos.yaml (1 hunks)
- .github/workflows/e2e-chaos.yaml (8 hunks)
- .github/workflows/e2e-code-bench-agent.yaml (2 hunks)
- .github/workflows/e2e-max-dim.yml (1 hunks)
- .github/workflows/e2e-profiling.yml (3 hunks)
- .github/workflows/e2e.yml (9 hunks)
- .github/workflows/helm.yml (1 hunks)
- Makefile (6 hunks)
- Makefile.d/dependencies.mk (5 hunks)
- Makefile.d/docker.mk (3 hunks)
- Makefile.d/e2e.mk (1 hunks)
- Makefile.d/helm.mk (1 hunks)
- Makefile.d/k3d.mk (2 hunks)
- Makefile.d/minikube.mk (1 hunks)
- Makefile.d/tools.mk (3 hunks)
- dockers/agent/core/agent/Dockerfile (2 hunks)
- dockers/agent/core/faiss/Dockerfile (2 hunks)
- dockers/agent/core/ngt/Dockerfile (2 hunks)
- dockers/agent/sidecar/Dockerfile (2 hunks)
- dockers/ci/base/Dockerfile (2 hunks)
- dockers/dev/Dockerfile (2 hunks)
- dockers/discoverer/k8s/Dockerfile (2 hunks)
- dockers/gateway/filter/Dockerfile (2 hunks)
- dockers/gateway/lb/Dockerfile (2 hunks)
- dockers/gateway/mirror/Dockerfile (2 hunks)
- dockers/index/job/correction/Dockerfile (2 hunks)
- dockers/index/job/creation/Dockerfile (2 hunks)
- dockers/index/job/readreplica/rotate/Dockerfile (2 hunks)
- dockers/index/job/save/Dockerfile (2 hunks)
- dockers/index/operator/Dockerfile (2 hunks)
- dockers/manager/index/Dockerfile (2 hunks)
- dockers/operator/helm/Dockerfile (4 hunks)
- dockers/tools/benchmark/job/Dockerfile (2 hunks)
- dockers/tools/benchmark/operator/Dockerfile (2 hunks)
- dockers/tools/cli/loadtest/Dockerfile (2 hunks)
- example/client/go.mod (2 hunks)
- go.mod (12 hunks)
- hack/docker/gen/main.go (23 hunks)
- hack/go.mod.default (1 hunks)
- hack/license/gen/main.go (2 hunks)
- pkg/agent/core/ngt/handler/grpc/insert.go (1 hunks)
- pkg/agent/core/ngt/handler/grpc/insert_test.go (3 hunks)
- pkg/agent/core/ngt/handler/grpc/search_test.go (1 hunks)
- rust/rust-toolchain (1 hunks)
- rust/rust-toolchain.toml (1 hunks)
- tests/e2e/kubernetes/portforward/portforward.go (1 hunks)
- versions/CMAKE_VERSION (1 hunks)
- versions/JAEGER_OPERATOR_VERSION (1 hunks)
- versions/OPERATOR_SDK_VERSION (1 hunks)
- versions/PROMETHEUS_STACK_VERSION (1 hunks)
- versions/PROTOBUF_VERSION (1 hunks)
Files not processed due to max files limit (1)
- versions/RUST_VERSION
Files skipped from review due to trivial changes (8)
- .github/PULL_REQUEST_TEMPLATE.md
- example/client/go.mod
- pkg/agent/core/ngt/handler/grpc/insert_test.go
- rust/rust-toolchain
- versions/CMAKE_VERSION
- versions/OPERATOR_SDK_VERSION
- versions/PROMETHEUS_STACK_VERSION
- versions/PROTOBUF_VERSION
Files skipped from review as they are similar to previous changes (39)
- .gitfiles
- .github/ISSUE_TEMPLATE/bug_report.md
- .github/ISSUE_TEMPLATE/security_issue_report.md
- .github/actions/setup-e2e/action.yaml
- .github/actions/setup-k3d/action.yaml
- .github/helm/values/values-chaos.yaml
- .github/workflows/e2e-code-bench-agent.yaml
- .github/workflows/e2e-max-dim.yml
- .github/workflows/helm.yml
- Makefile
- Makefile.d/dependencies.mk
- Makefile.d/docker.mk
- Makefile.d/e2e.mk
- Makefile.d/helm.mk
- Makefile.d/k3d.mk
- Makefile.d/minikube.mk
- Makefile.d/tools.mk
- dockers/agent/core/agent/Dockerfile
- dockers/agent/sidecar/Dockerfile
- dockers/ci/base/Dockerfile
- dockers/dev/Dockerfile
- dockers/gateway/filter/Dockerfile
- dockers/gateway/lb/Dockerfile
- dockers/gateway/mirror/Dockerfile
- dockers/index/job/readreplica/rotate/Dockerfile
- dockers/index/job/save/Dockerfile
- dockers/index/operator/Dockerfile
- dockers/manager/index/Dockerfile
- dockers/operator/helm/Dockerfile
- dockers/tools/benchmark/job/Dockerfile
- dockers/tools/benchmark/operator/Dockerfile
- dockers/tools/cli/loadtest/Dockerfile
- go.mod
- hack/docker/gen/main.go
- hack/go.mod.default
- pkg/agent/core/ngt/handler/grpc/search_test.go
- rust/rust-toolchain.toml
- tests/e2e/kubernetes/portforward/portforward.go
- versions/JAEGER_OPERATOR_VERSION
Additional comments not posted (33)
dockers/discoverer/k8s/Dockerfile (4)
41-46: LGTM! Environment variables for localization and timezone.Setting
LANGUAGE,LC_ALL, andTZis a good practice for localization and timezone configuration.
92-93: LGTM! Correct usage ofCOPYcommand.The
COPYcommand is correctly used to copy the necessary configuration files.
93-93: LGTM! Using non-root user.Using a non-root user is a good practice for security.
27-27: Security Concern: Running as root.Running the container as root can pose security risks. Consider using a non-root user unless absolutely necessary.
- USER root:root + USER nonroot:nonrootLikely invalid or redundant comment.
dockers/index/job/creation/Dockerfile (3)
41-46: LGTM! Environment variables for localization and timezone.Setting
LANGUAGE,LC_ALL, andTZis a good practice for localization and timezone configuration.
92-93: LGTM! Correct usage ofCOPYcommand.The
COPYcommand is correctly used to copy the necessary configuration files.
93-93: LGTM! Using non-root user.Using a non-root user is a good practice for security.
dockers/index/job/correction/Dockerfile (3)
41-46: LGTM! Environment variables for localization and timezone.Setting
LANGUAGE,LC_ALL, andTZis a good practice for localization and timezone configuration.
92-93: LGTM! Correct usage ofCOPYcommand.The
COPYcommand is correctly used to copy the necessary configuration files.
93-93: LGTM! Using non-root user.Using a non-root user is a good practice for security.
dockers/agent/core/ngt/Dockerfile (5)
41-42: LGTM!Setting locale environment variables improves localization within the container.
46-46: LGTM!Setting the timezone environment variable improves timezone management within the container.
101-101: LGTM!Copying the configuration file directly from the build context is a good practice.
102-102: LGTM!Using a non-root user improves security within the container.
27-27: Security Concern: Running as root.Running the container as root can pose security risks. Consider using a non-root user unless absolutely necessary.
- USER root:root + USER nonroot:nonrootLikely invalid or redundant comment.
dockers/agent/core/faiss/Dockerfile (5)
41-42: LGTM!Setting locale environment variables improves localization within the container.
46-46: LGTM!Setting the timezone environment variable improves timezone management within the container.
103-103: LGTM!Copying the configuration file directly from the build context is a good practice.
104-104: LGTM!Using a non-root user improves security within the container.
27-27: Security Concern: Running as root.Running the container as root can pose security risks. Consider using a non-root user unless absolutely necessary.
- USER root:root + USER nonroot:nonrootLikely invalid or redundant comment.
.github/workflows/e2e-chaos.yaml (4)
38-39: LGTM!Adding the
detect-ci-containerjob improves the workflow's adaptability by ensuring the correct container image is used.
42-47: LGTM!Specifying the container image based on the
detect-ci-containerjob ensures the correct environment is used.
83-88: LGTM!Specifying the container image based on the
detect-ci-containerjob ensures the correct environment is used.
Line range hint
124-170:
LGTM!Specifying the container images based on the
detect-ci-containerjob ensures the correct environment is used..github/workflows/e2e-profiling.yml (3)
40-40: LGTM! The dependency change is appropriate.The
e2e-profilingjob now depends ondetect-ci-containerinstead ofdump-contexts-to-log. This change is approved.
35-37: Verify the condition for thedetect-ci-containerjob.The job
detect-ci-containeris configured to run only on specific events (tagged refs or labeled PRs). Ensure that these conditions align with the intended workflow.
43-45: Verify the container configuration for thee2e-profilingjob.The job now includes a container specification with a dynamically tagged image. Ensure that the dynamic tagging works as intended.
Verification successful
Let's first verify the existence of the
.github/workflows/e2e-profiling.ymlfile and then refine our search to ensure the pattern matches correctly.
Verification successful: The container configuration for the
e2e-profilingjob is correctly set up with the dynamically tagged image.
- The file
.github/workflows/e2e-profiling.ymlexists.- The dynamically tagged image pattern is correctly present.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the container configuration for the `e2e-profiling` job. # Test: Check for the dynamically tagged image in the workflow file. rg --type yaml 'image: ghcr.io/vdaas/vald/vald-ci-container:\$\{\{ needs.detect-ci-container.outputs.TAG \}\}'Length of output: 112
Script:
#!/bin/bash # Check if the .github/workflows/e2e-profiling.yml file exists if [ -f ".github/workflows/e2e-profiling.yml" ]; then echo "File exists" else echo "File does not exist" fi # If the file exists, search for the dynamically tagged image pattern if [ -f ".github/workflows/e2e-profiling.yml" ]; then rg 'image: ghcr.io/vdaas/vald/vald-ci-container:\$\{\{ needs.detect-ci-container.outputs.TAG \}\}' .github/workflows/e2e-profiling.yml fiLength of output: 362
pkg/agent/core/ngt/handler/grpc/insert.go (1)
102-102: LGTM! The improved error handling logic is appropriate.The error handling logic now includes cases where an invalid ID or vector is provided. This improves the specificity and clarity of error messages.
.github/workflows/e2e.yml (3)
40-40: LGTM! The dependency change is appropriate.Several jobs now depend on
detect-ci-containerinstead ofdump-contexts-to-log. This change is approved.Also applies to: 81-81, 145-145, 190-190, 231-231, 268-268, 302-302, 353-353
35-37: Verify the condition for thedetect-ci-containerjob.The job
detect-ci-containeris configured to run only on specific events (tagged refs or labeled PRs). Ensure that these conditions align with the intended workflow.
43-45: Verify the container configuration for the jobs.Several jobs now include a container specification with a dynamically tagged image. Ensure that the dynamic tagging works as intended.
Also applies to: 84-86, 148-150, 193-195, 234-236, 272-273, 305-307, 356-358
hack/license/gen/main.go (2)
264-264: Simplified condition check.The condition checking if the
maintainervariable is empty has been simplified for better readability.
210-218: LGTM! Verify the impact of the changes to the directory entries.The change updates the directory entries recognized by the
dirwalkfunction. Ensure that the removal of"FAISS_VERSION"and the addition of"rust-toolchain"align with the intended behavior.Verify if any other parts of the codebase depend on the
"FAISS_VERSION"entry.
Comments failed to post (7)
dockers/discoverer/k8s/Dockerfile
53-84: Pin package versions and optimize cleanup commands.
Pinning package versions ensures reproducibility and stability of the build. Additionally, ensure that cleanup commands are efficient to reduce image size.
- && apt-get install -y --no-install-recommends --fix-missing \ + && apt-get install -y --no-install-recommends --fix-missing \ + build-essential=12.8ubuntu1 \ + ca-certificates=20210119~20.04.2 \ + curl=7.68.0-1ubuntu2.6 \ + git=1:2.25.1-1ubuntu3.2 \ + tzdata=2021a-0ubuntu0.20.04 \ + locales=2.31-0ubuntu9.9 \ && apt-get clean \ && apt-get autoclean -y \ && apt-get autoremove -yCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.RUN --mount=type=bind,target=.,rw \ --mount=type=tmpfs,target=/tmp \ --mount=type=cache,target=/var/lib/apt,sharing=locked \ --mount=type=cache,target=/var/cache/apt,sharing=locked \ --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \ --mount=type=cache,target="${HOME}/.cache/go-build",id="go-build-${TARGETARCH}"\ echo 'Binary::apt::APT::Keep-Downloaded-Packages "true";' > /etc/apt/apt.conf.d/keep-cache \ && echo 'APT::Install-Recommends "false";' > /etc/apt/apt.conf.d/no-install-recommends \ && apt-get clean \ && apt-get update -y \ && apt-get upgrade -y \ && apt-get install -y --no-install-recommends --fix-missing \ build-essential=12.8ubuntu1 \ ca-certificates=20210119~20.04.2 \ curl=7.68.0-1ubuntu2.6 \ git=1:2.25.1-1ubuntu3.2 \ tzdata=2021a-0ubuntu0.20.04 \ locales=2.31-0ubuntu9.9 \ && ldconfig \ && echo "${LANG} UTF-8" > /etc/locale.gen \ && ln -fs /usr/share/zoneinfo/${TZ} /etc/localtime \ && locale-gen ${LANGUAGE} \ && update-locale LANG=${LANGUAGE} \ && dpkg-reconfigure -f noninteractive tzdata \ && apt-get clean \ && apt-get autoclean -y \ && apt-get autoremove -y \ && make GOPATH="${GOPATH}" GOROOT="${GOROOT}" GO_VERSION="${GO_VERSION}" go/install \ && make GOPATH="${GOPATH}" GOROOT="${GOROOT}" GO_VERSION="${GO_VERSION}" go/download \ && make GOARCH="${TARGETARCH}" GOOS="${TARGETOS}" REPO="${ORG}" NAME="${REPO}" cmd/${PKG}/${APP_NAME} \ && mv "cmd/${PKG}/${APP_NAME}" "/usr/bin/${APP_NAME}" # skipcq: DOK-DL3026,DOK-DL3007dockers/index/job/creation/Dockerfile
27-27: Security Concern: Running as root.
Running the container as root can pose security risks. Consider using a non-root user unless absolutely necessary.
- USER root:root + USER nonroot:nonrootCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.USER nonroot:nonroot
53-84: Pin package versions and optimize cleanup commands.
Pinning package versions ensures reproducibility and stability of the build. Additionally, ensure that cleanup commands are efficient to reduce image size.
- && apt-get install -y --no-install-recommends --fix-missing \ + && apt-get install -y --no-install-recommends --fix-missing \ + build-essential=12.8ubuntu1 \ + ca-certificates=20210119~20.04.2 \ + curl=7.68.0-1ubuntu2.6 \ + git=1:2.25.1-1ubuntu3.2 \ + tzdata=2021a-0ubuntu0.20.04 \ + locales=2.31-0ubuntu9.9 \ && apt-get clean \ && apt-get autoclean -y \ && apt-get autoremove -yCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.RUN --mount=type=bind,target=.,rw \ --mount=type=tmpfs,target=/tmp \ --mount=type=cache,target=/var/lib/apt,sharing=locked \ --mount=type=cache,target=/var/cache/apt,sharing=locked \ --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \ --mount=type=cache,target="${HOME}/.cache/go-build",id="go-build-${TARGETARCH}"\ echo 'Binary::apt::APT::Keep-Downloaded-Packages "true";' > /etc/apt/apt.conf.d/keep-cache \ && echo 'APT::Install-Recommends "false";' > /etc/apt/apt.conf.d/no-install-recommends \ && apt-get clean \ && apt-get update -y \ && apt-get upgrade -y \ && apt-get install -y --no-install-recommends --fix-missing \ build-essential=12.8ubuntu1 \ ca-certificates=20210119~20.04.2 \ curl=7.68.0-1ubuntu2.6 \ git=1:2.25.1-1ubuntu3.2 \ tzdata=2021a-0ubuntu0.20.04 \ locales=2.31-0ubuntu9.9 \ && ldconfig \ && echo "${LANG} UTF-8" > /etc/locale.gen \ && ln -fs /usr/share/zoneinfo/${TZ} /etc/localtime \ && locale-gen ${LANGUAGE} \ && update-locale LANG=${LANGUAGE} \ && dpkg-reconfigure -f noninteractive tzdata \ && apt-get clean \ && apt-get autoclean -y \ && apt-get autoremove -y \ && make GOPATH="${GOPATH}" GOROOT="${GOROOT}" GO_VERSION="${GO_VERSION}" go/install \ && make GOPATH="${GOPATH}" GOROOT="${GOROOT}" GO_VERSION="${GO_VERSION}" go/download \ && make GOARCH="${TARGETARCH}" GOOS="${TARGETOS}" REPO="${ORG}" NAME="${REPO}" cmd/${PKG}/${APP_NAME} \ && mv "cmd/${PKG}/${APP_NAME}" "/usr/bin/${APP_NAME}" # skipcq: DOK-DL3026,DOK-DL3007dockers/index/job/correction/Dockerfile
27-27: Security Concern: Running as root.
Running the container as root can pose security risks. Consider using a non-root user unless absolutely necessary.
- USER root:root + USER nonroot:nonrootCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.USER nonroot:nonroot
53-84: Pin package versions and optimize cleanup commands.
Pinning package versions ensures reproducibility and stability of the build. Additionally, ensure that cleanup commands are efficient to reduce image size.
- && apt-get install -y --no-install-recommends --fix-missing \ + && apt-get install -y --no-install-recommends --fix-missing \ + build-essential=12.8ubuntu1 \ + ca-certificates=20210119~20.04.2 \ + curl=7.68.0-1ubuntu2.6 \ + git=1:2.25.1-1ubuntu3.2 \ + tzdata=2021a-0ubuntu0.20.04 \ + locales=2.31-0ubuntu9.9 \ && apt-get clean \ && apt-get autoclean -y \ && apt-get autoremove -yCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.RUN --mount=type=bind,target=.,rw \ --mount=type=tmpfs,target=/tmp \ --mount=type=cache,target=/var/lib/apt,sharing=locked \ --mount=type=cache,target=/var/cache/apt,sharing=locked \ --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \ --mount=type=cache,target="${HOME}/.cache/go-build",id="go-build-${TARGETARCH}"\ echo 'Binary::apt::APT::Keep-Downloaded-Packages "true";' > /etc/apt/apt.conf.d/keep-cache \ && echo 'APT::Install-Recommends "false";' > /etc/apt/apt.conf.d/no-install-recommends \ && apt-get clean \ && apt-get update -y \ && apt-get upgrade -y \ && apt-get install -y --no-install-recommends --fix-missing \ build-essential=12.8ubuntu1 \ ca-certificates=20210119~20.04.2 \ curl=7.68.0-1ubuntu2.6 \ git=1:2.25.1-1ubuntu3.2 \ tzdata=2021a-0ubuntu0.20.04 \ locales=2.31-0ubuntu9.9 \ && ldconfig \ && echo "${LANG} UTF-8" > /etc/locale.gen \ && ln -fs /usr/share/zoneinfo/${TZ} /etc/localtime \ && locale-gen ${LANGUAGE} \ && update-locale LANG=${LANGUAGE} \ && dpkg-reconfigure -f noninteractive tzdata \ && apt-get clean \ && apt-get autoclean -y \ && apt-get autoremove -y \ && make GOPATH="${GOPATH}" GOROOT="${GOROOT}" GO_VERSION="${GO_VERSION}" go/install \ && make GOPATH="${GOPATH}" GOROOT="${GOROOT}" GO_VERSION="${GO_VERSION}" go/download \ && make GOARCH="${TARGETARCH}" GOOS="${TARGETOS}" REPO="${ORG}" NAME="${REPO}" cmd/${PKG}/${APP_NAME} \ && mv "cmd/${PKG}/${APP_NAME}" "/usr/bin/${APP_NAME}" # skipcq: DOK-DL3026,DOK-DL3007dockers/agent/core/ngt/Dockerfile
53-89: Pin versions in
apt-get install.Pinning package versions ensures consistent builds and stability.
- && apt-get install -y --no-install-recommends --fix-missing \ + && apt-get install -y --no-install-recommends --fix-missing \ + build-essential=12.8ubuntu1.1 \ + ca-certificates=20210119~20.04.2 \ + curl=7.68.0-1ubuntu2.6 \ + tzdata=2021a-0ubuntu0.20.04 \ + locales=2.31-0ubuntu9.9 \ + git=1:2.25.1-1ubuntu3.2 \ + cmake=3.16.3-1ubuntu1 \ + gcc=4:9.3.0-1ubuntu2 \ + g++=4:9.3.0-1ubuntu2 \ + unzip=6.0-25ubuntu1 \ + libssl-dev=1.1.1f-1ubuntu2.16 \ + liblapack-dev=3.9.0-1build1 \ + libomp-dev=10.0.0-4ubuntu1 \ + libopenblas-dev=0.3.8+ds-1ubuntu0.20.04.1 \ + gfortran=4:9.3.0-1ubuntu2 \ + libquadmath0=10.2.0-5ubuntu1~20.04Committable suggestion was skipped due to low confidence.
dockers/agent/core/faiss/Dockerfile
53-89: Pin versions in
apt-get install.Pinning package versions ensures consistent builds and stability.
- && apt-get install -y --no-install-recommends --fix-missing \ + && apt-get install -y --no-install-recommends --fix-missing \ + build-essential=12.8ubuntu1.1 \ + ca-certificates=20210119~20.04.2 \ + curl=7.68.0-1ubuntu2.6 \ + tzdata=2021a-0ubuntu0.20.04 \ + locales=2.31-0ubuntu9.9 \ + git=1:2.25.1-1ubuntu3.2 \ + cmake=3.16.3-1ubuntu1 \ + gcc=4:9.3.0-1ubuntu2 \ + g++=4:9.3.0-1ubuntu2 \ + unzip=6.0-25ubuntu1 \ + libssl-dev=1.1.1f-1ubuntu2.16 \ + liblapack-dev=3.9.0-1build1 \ + libomp-dev=10.0.0-4ubuntu1 \ + libopenblas-dev=0.3.8+ds-1ubuntu0.20.04.1 \ + gfortran=4:9.3.0-1ubuntu2 \ + libquadmath0=10.2.0-5ubuntu1~20.04Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.RUN --mount=type=bind,target=.,rw \ --mount=type=tmpfs,target=/tmp \ --mount=type=cache,target=/var/lib/apt,sharing=locked \ --mount=type=cache,target=/var/cache/apt,sharing=locked \ --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \ --mount=type=cache,target="${HOME}/.cache/go-build",id="go-build-${TARGETARCH}"\ echo 'Binary::apt::APT::Keep-Downloaded-Packages "true";' > /etc/apt/apt.conf.d/keep-cache \ && echo 'APT::Install-Recommends "false";' > /etc/apt/apt.conf.d/no-install-recommends \ && apt-get clean \ && apt-get update -y \ && apt-get upgrade -y \ && apt-get install -y --no-install-recommends --fix-missing \ build-essential=12.8ubuntu1.1 \ ca-certificates=20210119~20.04.2 \ curl=7.68.0-1ubuntu2.6 \ tzdata=2021a-0ubuntu0.20.04 \ locales=2.31-0ubuntu9.9 \ git=1:2.25.1-1ubuntu3.2 \ cmake=3.16.3-1ubuntu1 \ gcc=4:9.3.0-1ubuntu2 \ g++=4:9.3.0-1ubuntu2 \ unzip=6.0-25ubuntu1 \ libssl-dev=1.1.1f-1ubuntu2.16 \ liblapack-dev=3.9.0-1build1 \ libomp-dev=10.0.0-4ubuntu1 \ libopenblas-dev=0.3.8+ds-1ubuntu0.20.04.1 \ gfortran=4:9.3.0-1ubuntu2 \ libquadmath0=10.2.0-5ubuntu1~20.04 \ && ldconfig \ && echo "${LANG} UTF-8" > /etc/locale.gen \ && ln -fs /usr/share/zoneinfo/${TZ} /etc/localtime \ && locale-gen ${LANGUAGE} \ && update-locale LANG=${LANGUAGE} \ && dpkg-reconfigure -f noninteractive tzdata \ && apt-get clean \ && apt-get autoclean -y \ && apt-get autoremove -y \
There was a problem hiding this comment.
Actionable comments posted: 14
Outside diff range, codebase verification and nitpick comments (2)
dockers/manager/index/Dockerfile (1)
41-46: Set locale and timezone environment variables earlier.Setting locale and timezone environment variables earlier in the Dockerfile ensures they are available for all subsequent commands.
ENV LANG=en_US.UTF-8 ENV LANGUAGE=en_US.UTF-8 ENV LC_ALL=en_US.UTF-8 ENV TZ=Etc/UTCdockers/discoverer/k8s/Dockerfile (1)
41-46: Set locale and timezone environment variables earlier.Setting locale and timezone environment variables earlier in the Dockerfile ensures they are available for all subsequent commands.
ENV LANG=en_US.UTF-8 ENV LANGUAGE=en_US.UTF-8 ENV LC_ALL=en_US.UTF-8 ENV TZ=Etc/UTC
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (3)
example/client/go.sumis excluded by!**/*.sumgo.sumis excluded by!**/*.sumrust/Cargo.lockis excluded by!**/*.lock
Files selected for processing (57)
- .gitfiles (6 hunks)
- .github/ISSUE_TEMPLATE/bug_report.md (1 hunks)
- .github/ISSUE_TEMPLATE/security_issue_report.md (1 hunks)
- .github/PULL_REQUEST_TEMPLATE.md (1 hunks)
- .github/actions/setup-e2e/action.yaml (2 hunks)
- .github/actions/setup-k3d/action.yaml (2 hunks)
- .github/helm/values/values-chaos.yaml (1 hunks)
- .github/workflows/e2e-chaos.yaml (8 hunks)
- .github/workflows/e2e-code-bench-agent.yaml (2 hunks)
- .github/workflows/e2e-max-dim.yml (1 hunks)
- .github/workflows/e2e-profiling.yml (3 hunks)
- .github/workflows/e2e.yml (9 hunks)
- .github/workflows/helm.yml (1 hunks)
- Makefile (6 hunks)
- Makefile.d/dependencies.mk (5 hunks)
- Makefile.d/docker.mk (3 hunks)
- Makefile.d/e2e.mk (1 hunks)
- Makefile.d/helm.mk (1 hunks)
- Makefile.d/k3d.mk (2 hunks)
- Makefile.d/minikube.mk (1 hunks)
- Makefile.d/tools.mk (3 hunks)
- dockers/agent/core/agent/Dockerfile (2 hunks)
- dockers/agent/core/faiss/Dockerfile (2 hunks)
- dockers/agent/core/ngt/Dockerfile (2 hunks)
- dockers/agent/sidecar/Dockerfile (2 hunks)
- dockers/ci/base/Dockerfile (2 hunks)
- dockers/dev/Dockerfile (2 hunks)
- dockers/discoverer/k8s/Dockerfile (2 hunks)
- dockers/gateway/filter/Dockerfile (2 hunks)
- dockers/gateway/lb/Dockerfile (2 hunks)
- dockers/gateway/mirror/Dockerfile (2 hunks)
- dockers/index/job/correction/Dockerfile (2 hunks)
- dockers/index/job/creation/Dockerfile (2 hunks)
- dockers/index/job/readreplica/rotate/Dockerfile (2 hunks)
- dockers/index/job/save/Dockerfile (2 hunks)
- dockers/index/operator/Dockerfile (2 hunks)
- dockers/manager/index/Dockerfile (2 hunks)
- dockers/operator/helm/Dockerfile (4 hunks)
- dockers/tools/benchmark/job/Dockerfile (2 hunks)
- dockers/tools/benchmark/operator/Dockerfile (2 hunks)
- dockers/tools/cli/loadtest/Dockerfile (2 hunks)
- example/client/go.mod (2 hunks)
- go.mod (12 hunks)
- hack/docker/gen/main.go (23 hunks)
- hack/go.mod.default (1 hunks)
- hack/license/gen/main.go (2 hunks)
- pkg/agent/core/ngt/handler/grpc/insert.go (1 hunks)
- pkg/agent/core/ngt/handler/grpc/insert_test.go (3 hunks)
- pkg/agent/core/ngt/handler/grpc/search_test.go (1 hunks)
- rust/rust-toolchain (1 hunks)
- rust/rust-toolchain.toml (1 hunks)
- tests/e2e/kubernetes/portforward/portforward.go (1 hunks)
- versions/CMAKE_VERSION (1 hunks)
- versions/JAEGER_OPERATOR_VERSION (1 hunks)
- versions/OPERATOR_SDK_VERSION (1 hunks)
- versions/PROMETHEUS_STACK_VERSION (1 hunks)
- versions/PROTOBUF_VERSION (1 hunks)
Files not processed due to max files limit (1)
- versions/RUST_VERSION
Files skipped from review due to trivial changes (9)
- .github/PULL_REQUEST_TEMPLATE.md
- Makefile.d/minikube.mk
- example/client/go.mod
- pkg/agent/core/ngt/handler/grpc/insert_test.go
- rust/rust-toolchain
- versions/CMAKE_VERSION
- versions/OPERATOR_SDK_VERSION
- versions/PROMETHEUS_STACK_VERSION
- versions/PROTOBUF_VERSION
Files skipped from review as they are similar to previous changes (35)
- .gitfiles
- .github/ISSUE_TEMPLATE/bug_report.md
- .github/ISSUE_TEMPLATE/security_issue_report.md
- .github/actions/setup-e2e/action.yaml
- .github/helm/values/values-chaos.yaml
- .github/workflows/e2e-max-dim.yml
- .github/workflows/helm.yml
- Makefile
- Makefile.d/dependencies.mk
- Makefile.d/docker.mk
- Makefile.d/e2e.mk
- Makefile.d/helm.mk
- Makefile.d/k3d.mk
- Makefile.d/tools.mk
- dockers/agent/core/agent/Dockerfile
- dockers/agent/core/ngt/Dockerfile
- dockers/agent/sidecar/Dockerfile
- dockers/ci/base/Dockerfile
- dockers/dev/Dockerfile
- dockers/gateway/filter/Dockerfile
- dockers/gateway/lb/Dockerfile
- dockers/gateway/mirror/Dockerfile
- dockers/index/job/correction/Dockerfile
- dockers/index/job/save/Dockerfile
- dockers/index/operator/Dockerfile
- dockers/operator/helm/Dockerfile
- dockers/tools/benchmark/job/Dockerfile
- dockers/tools/benchmark/operator/Dockerfile
- dockers/tools/cli/loadtest/Dockerfile
- go.mod
- hack/go.mod.default
- pkg/agent/core/ngt/handler/grpc/insert.go
- pkg/agent/core/ngt/handler/grpc/search_test.go
- tests/e2e/kubernetes/portforward/portforward.go
- versions/JAEGER_OPERATOR_VERSION
Additional context used
GitHub Check: codecov/patch
hack/license/gen/main.go
[warning] 264-264: hack/license/gen/main.go#L264
Added line #L264 was not covered by testshack/docker/gen/main.go
[warning] 172-174: hack/docker/gen/main.go#L172-L174
Added lines #L172 - L174 were not covered by tests
[warning] 176-179: hack/docker/gen/main.go#L176-L179
Added lines #L176 - L179 were not covered by tests
[warning] 181-181: hack/docker/gen/main.go#L181
Added line #L181 was not covered by tests
[warning] 183-183: hack/docker/gen/main.go#L183
Added line #L183 was not covered by tests
[warning] 192-194: hack/docker/gen/main.go#L192-L194
Added lines #L192 - L194 were not covered by tests
[warning] 265-266: hack/docker/gen/main.go#L265-L266
Added lines #L265 - L266 were not covered by tests
[warning] 428-429: hack/docker/gen/main.go#L428-L429
Added lines #L428 - L429 were not covered by tests
[warning] 505-505: hack/docker/gen/main.go#L505
Added line #L505 was not covered by tests
[warning] 508-508: hack/docker/gen/main.go#L508
Added line #L508 was not covered by tests
[warning] 515-518: hack/docker/gen/main.go#L515-L518
Added lines #L515 - L518 were not covered by tests
[warning] 521-522: hack/docker/gen/main.go#L521-L522
Added lines #L521 - L522 were not covered by tests
[warning] 542-543: hack/docker/gen/main.go#L542-L543
Added lines #L542 - L543 were not covered by tests
[warning] 646-646: hack/docker/gen/main.go#L646
Added line #L646 was not covered by tests
[warning] 648-649: hack/docker/gen/main.go#L648-L649
Added lines #L648 - L649 were not covered by tests
[warning] 652-654: hack/docker/gen/main.go#L652-L654
Added lines #L652 - L654 were not covered by tests
[warning] 658-661: hack/docker/gen/main.go#L658-L661
Added lines #L658 - L661 were not covered by tests
[warning] 668-669: hack/docker/gen/main.go#L668-L669
Added lines #L668 - L669 were not covered by tests
[warning] 695-696: hack/docker/gen/main.go#L695-L696
Added lines #L695 - L696 were not covered by tests
[warning] 699-700: hack/docker/gen/main.go#L699-L700
Added lines #L699 - L700 were not covered by tests
[warning] 722-725: hack/docker/gen/main.go#L722-L725
Added lines #L722 - L725 were not covered by tests
[warning] 734-738: hack/docker/gen/main.go#L734-L738
Added lines #L734 - L738 were not covered by tests
[warning] 740-740: hack/docker/gen/main.go#L740
Added line #L740 was not covered by tests
[warning] 747-750: hack/docker/gen/main.go#L747-L750
Added lines #L747 - L750 were not covered by tests
[warning] 760-763: hack/docker/gen/main.go#L760-L763
Added lines #L760 - L763 were not covered by tests
[warning] 768-774: hack/docker/gen/main.go#L768-L774
Added lines #L768 - L774 were not covered by tests
[warning] 776-777: hack/docker/gen/main.go#L776-L777
Added lines #L776 - L777 were not covered by tests
[warning] 786-786: hack/docker/gen/main.go#L786
Added line #L786 was not covered by tests
Additional comments not posted (35)
dockers/manager/index/Dockerfile (1)
27-27: Security Concern: Avoid using root user.The
USERdirective sets the user toroot:root, which poses security risks. Consider using a non-root user.- USER root:root + USER nonroot:nonrootLikely invalid or redundant comment.
dockers/index/job/creation/Dockerfile (3)
41-47: LGTM!The environment variables for locale and timezone settings enhance the container's internationalization and localization capabilities.
82-86: LGTM!The commands for locale generation and timezone setup ensure the environment is correctly configured for internationalization.
88-89: LGTM!The cleanup commands optimize the image size by removing unnecessary files.
dockers/index/job/readreplica/rotate/Dockerfile (3)
41-47: LGTM!The environment variables for locale and timezone settings enhance the container's internationalization and localization capabilities.
82-86: LGTM!The commands for locale generation and timezone setup ensure the environment is correctly configured for internationalization.
88-89: LGTM!The cleanup commands optimize the image size by removing unnecessary files.
dockers/agent/core/faiss/Dockerfile (4)
41-47: LGTM!The environment variables for locale and timezone settings enhance the container's internationalization and localization capabilities.
82-86: LGTM!The commands for locale generation and timezone setup ensure the environment is correctly configured for internationalization.
88-89: LGTM!The cleanup commands optimize the image size by removing unnecessary files.
27-27: Security Concern: Running as root.Running the container as root can pose security risks. Consider using a non-root user unless absolutely necessary.
- USER root:root + USER nonroot:nonrootLikely invalid or redundant comment.
.github/actions/setup-k3d/action.yaml (3)
60-67: Verify default value logic forK3S_VERSION.Ensure that the default value logic for
K3S_VERSIONis necessary and not redundant, similar to the default values forK3D_CLUSTER_NAMEandK3D_NODES.
99-101: LGTM!The code changes are approved.
104-111: LGTM!The code changes are approved.
.github/workflows/e2e-code-bench-agent.yaml (2)
61-61: LGTM!The code changes are approved.
89-89: LGTM!The code changes are approved.
.github/workflows/e2e-chaos.yaml (5)
37-39: LGTM!The code changes are approved.
42-47: LGTM!The code changes are approved.
83-88: LGTM!The code changes are approved.
124-129: LGTM!The code changes are approved.
165-170: LGTM!The code changes are approved.
.github/workflows/e2e-profiling.yml (2)
35-37: New jobdetect-ci-containeradded.The job
detect-ci-containerhas been correctly added and integrated into the workflow.
40-45: Jobe2e-profilingupdated.The job
e2e-profilinghas been correctly updated to depend ondetect-ci-containerand includes a container specification..github/workflows/e2e.yml (9)
35-37: New jobdetect-ci-containeradded.The job
detect-ci-containerhas been correctly added and integrated into the workflow.
40-45: Jobe2e-stream-crudupdated.The job
e2e-stream-crudhas been correctly updated to depend ondetect-ci-containerand includes a container specification.
81-86: Jobe2e-stream-crud-for-operatorupdated.The job
e2e-stream-crud-for-operatorhas been correctly updated to depend ondetect-ci-containerand includes a container specification.
145-150: Jobe2e-stream-crud-under-index-management-jobsupdated.The job
e2e-stream-crud-under-index-management-jobshas been correctly updated to depend ondetect-ci-containerand includes a container specification.
190-195: Jobe2e-stream-crud-skip-exist-checkupdated.The job
e2e-stream-crud-skip-exist-checkhas been correctly updated to depend ondetect-ci-containerand includes a container specification.
231-236: Jobe2e-multiapis-crudupdated.The job
e2e-multiapis-crudhas been correctly updated to depend ondetect-ci-containerand includes a container specification.
268-273: Jobe2e-jobsupdated.The job
e2e-jobshas been correctly updated to depend ondetect-ci-containerand includes a container specification.
302-307: Jobe2e-stream-crud-with-readreplicaupdated.The job
e2e-stream-crud-with-readreplicahas been correctly updated to depend ondetect-ci-containerand includes a container specification.
353-358: Jobe2e-stream-crud-with-mirrorupdated.The job
e2e-stream-crud-with-mirrorhas been correctly updated to depend ondetect-ci-containerand includes a container specification.hack/license/gen/main.go (2)
210-218: Functiondirwalkupdated.The function
dirwalkhas been correctly updated to remove the string literal"FAISS_VERSION"and add the string"rust-toolchain".
264-264: FunctionreadAndRewriteupdated.The condition checking if the
maintainervariable is empty has been correctly simplified.Tools
GitHub Check: codecov/patch
[warning] 264-264: hack/license/gen/main.go#L264
Added line #L264 was not covered by testshack/docker/gen/main.go (1)
40-40: Initializetmplwithfmt.SprintfThe initialization of
tmplwithfmt.Sprintfis correct and improves flexibility in template generation.
… build systems and localization (#2549) Signed-off-by: kpango <kpango@vdaas.org>
fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Sync release/v1.7 to main (#2495) add read replica and rotator docs (#2497) (#2499) add reviewer guideline (#2507) (#2508) update large top-K ratio handling logic (#2509) (#2511) Change default image tag from latest to nightly (#2516) (#2518) Bugfix that caused an error when argument has 3 or more nil arguments (#2517) (#2520) add faiss in values.yaml & valdrelease.yaml (#2514) (#2519) capitalize faq (#2512) (#2522) Backport docs updates to release/v1.7 (#2521) [CI] Add workflow to synchronize ubuntu base image (#2526) (#2527) fix: update schedule (#2528) (#2530) refactor index manager service add index service API to expose index informations (#2525) (#2532) fix conflict bug (#2537) fix: make format (#2534) (#2540) Backport PR #2542, #2538 to release/v1.7 (#2543) fix: add checkout option (#2545) (#2546) Implement ngt Statistics API (#2539) (#2547) Add workflow to check git conflict for backport PR (#2548) (#2550) [create-pull-request] automated change (#2552) (#2556) Update dependencies, C++ standard, and improve Dockerfiles for better build systems and localization (#2549) (#2557) Backport #2559 (#2560) [BUGFIX] index correction process (#2565) (#2566) change external docker image reference to ghcr.io registry (#2567) (#2568) [patch] Release v1.7.13 (#2569) :bookmark: :robot: Release v1.7.13 (#2570) add HTTP2 support for http.Client and Vald HTTP Server (#2572) (#2575) Signed-off-by: kpango <kpango@vdaas.org>
fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Sync release/v1.7 to main (#2495) add read replica and rotator docs (#2497) (#2499) add reviewer guideline (#2507) (#2508) update large top-K ratio handling logic (#2509) (#2511) Change default image tag from latest to nightly (#2516) (#2518) Bugfix that caused an error when argument has 3 or more nil arguments (#2517) (#2520) add faiss in values.yaml & valdrelease.yaml (#2514) (#2519) capitalize faq (#2512) (#2522) Backport docs updates to release/v1.7 (#2521) [CI] Add workflow to synchronize ubuntu base image (#2526) (#2527) fix: update schedule (#2528) (#2530) refactor index manager service add index service API to expose index informations (#2525) (#2532) fix conflict bug (#2537) fix: make format (#2534) (#2540) Backport PR #2542, #2538 to release/v1.7 (#2543) fix: add checkout option (#2545) (#2546) Implement ngt Statistics API (#2539) (#2547) Add workflow to check git conflict for backport PR (#2548) (#2550) [create-pull-request] automated change (#2552) (#2556) Update dependencies, C++ standard, and improve Dockerfiles for better build systems and localization (#2549) (#2557) Backport #2559 (#2560) [BUGFIX] index correction process (#2565) (#2566) change external docker image reference to ghcr.io registry (#2567) (#2568) [patch] Release v1.7.13 (#2569) :bookmark: :robot: Release v1.7.13 (#2570) add HTTP2 support for http.Client and Vald HTTP Server (#2572) (#2575) Signed-off-by: kpango <kpango@vdaas.org>
fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Sync release/v1.7 to main (#2495) add read replica and rotator docs (#2497) (#2499) add reviewer guideline (#2507) (#2508) update large top-K ratio handling logic (#2509) (#2511) Change default image tag from latest to nightly (#2516) (#2518) Bugfix that caused an error when argument has 3 or more nil arguments (#2517) (#2520) add faiss in values.yaml & valdrelease.yaml (#2514) (#2519) capitalize faq (#2512) (#2522) Backport docs updates to release/v1.7 (#2521) [CI] Add workflow to synchronize ubuntu base image (#2526) (#2527) fix: update schedule (#2528) (#2530) refactor index manager service add index service API to expose index informations (#2525) (#2532) fix conflict bug (#2537) fix: make format (#2534) (#2540) Backport PR #2542, #2538 to release/v1.7 (#2543) fix: add checkout option (#2545) (#2546) Implement ngt Statistics API (#2539) (#2547) Add workflow to check git conflict for backport PR (#2548) (#2550) [create-pull-request] automated change (#2552) (#2556) Update dependencies, C++ standard, and improve Dockerfiles for better build systems and localization (#2549) (#2557) Backport #2559 (#2560) [BUGFIX] index correction process (#2565) (#2566) change external docker image reference to ghcr.io registry (#2567) (#2568) [patch] Release v1.7.13 (#2569) :bookmark: :robot: Release v1.7.13 (#2570) add HTTP2 support for http.Client and Vald HTTP Server (#2572) (#2575) Signed-off-by: kpango <kpango@vdaas.org>
Description
This commit includes updates to various dependencies, Dockerfile enhancements, and build configuration improvements:
Dependency Updates:
Upgraded modules in go.mod, including code.cloudfoundry.org/bytefmt, github.com/aws/aws-sdk-go, github.com/google/pprof, github.com/onsi/ginkgo/v2, and several Kubernetes-related modules.
Makefile Changes:
Updated C++ standard from gnu++20 to gnu++23.
Specified build directories for NGT and FAISS using the -B option.
Added a target for CMake installation, including cloning the repository and configuring build parameters.
Dockerfile Enhancements:
Set environment variables for locale (LANGUAGE, LC_ALL) and timezone (TZ).
Added packages like locales and tzdata for locale generation and timezone management.
Improved cleanup commands with apt-get autoclean -y for a cleaner build process.
Set the USER directive to root:root to affect permissions during the build process.
Rust Toolchain Updates:
Updated Rust version to 1.80.0.
Version File Updates:
CMake version set to 3.30.1.
Updated Jaeger Operator from 2.54.0 to 2.55.0.
Rolled back Operator SDK from v1.35 to v1.33.
Updated Prometheus Stack from 61.3.2 to 61.6.0.
Updated Rust version from 1.77.2 to 1.80.0.
These changes aim to improve the build process, localization, and timezone management within the containers, ensuring a more efficient and consistent development environment.
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Chores