Skip to content

docs(enriching): Remove misleading documentation about supported databases#15714

Merged
jszwedko merged 1 commit into
masterfrom
jszwedko/remove-misleading-geoip-doc
Dec 23, 2022
Merged

docs(enriching): Remove misleading documentation about supported databases#15714
jszwedko merged 1 commit into
masterfrom
jszwedko/remove-misleading-geoip-doc

Conversation

@jszwedko
Copy link
Copy Markdown
Collaborator

@jszwedko jszwedko commented Dec 23, 2022

The supported databases are already listed under the geoip type for enrichment tables.

Closes: #15686

Signed-off-by: Jesse Szwedko jesse.szwedko@datadoghq.com

…bases

The supported databases are already listed under the `geoip` type for enrichment tables.

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 23, 2022

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit 1a10a15
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/63a5bf2d783030000a4de6b4
😎 Deploy Preview https://deploy-preview-15714--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 23, 2022

Deploy Preview for vrl-playground canceled.

Name Link
🔨 Latest commit 1a10a15
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/63a5bf2de4ea4f0009bc706f

@github-actions github-actions Bot added the domain: external docs Anything related to Vector's external, public documentation label Dec 23, 2022
Copy link
Copy Markdown
Contributor

@spencergilbert spencergilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth linking to where we correctly document it, or at least stating where to look.

@jszwedko
Copy link
Copy Markdown
Collaborator Author

Probably worth linking to where we correctly document it, or at least stating where to look.

The supported databases are rendered right above this option so I think it is a bit redundant.

Copy link
Copy Markdown
Contributor

@spencergilbert spencergilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, I thought it was documented in the VRL side of things.

@jszwedko jszwedko merged commit e3e231f into master Dec 23, 2022
@jszwedko jszwedko deleted the jszwedko/remove-misleading-geoip-doc branch December 23, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: external docs Anything related to Vector's external, public documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

encrichment tables removes support for GeoIP-ASN and other databases (Regression)

2 participants