-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(new transform): Add new window transform
#22609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
joepeeples
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small line edit suggestions but otherwise LGTM, thanks!
Co-authored-by: Joe Peeples <joe.peeples@datadoghq.com>
|
I think I liked more the |
I chose a new name because I felt that The |
|
Thank you for the review and edits @joepeeples. I thought the original description of the transform was not great, so I decided to update it. Would you mind taking a look a the changes I made in commit 92ae4af? |
Thank you @ilinas. This PR is on my radar. I will do a proper review soon! |
pront
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks @ilinas. I left some comments, mostly nits.
|
I think this is the final version of the code. |
Nice! I will do one more review but we can easily include this in the next release. |
|
@ilinas this looks like a good first version! |
|
Please |
|
@pront I could use some help figuring out what is it failing on this time? |
Not sure, you can try merging the latest |
* feat(new transform): Add window transform * Fix spelling errors * Reformat cue docs * Apply documentation changes from code review Co-authored-by: Joe Peeples <joe.peeples@datadoghq.com> * Generate component docs * Update transform description * Add a more detailed changelog * Rename config variables, update docs --------- Co-authored-by: Joe Peeples <joe.peeples@datadoghq.com> Co-authored-by: Pavlos Rontidis <pavlos.rontidis@gmail.com>


Summary
A variant of ring buffer / backtrace logging. Keeps events in a buffer until a trigger is encountered and the buffer is flushed. When the buffer is full, the oldest events are being dropped, and it works pretty much like the
filtertransform.This is rewrite of my previous PR #21071 with the complexity and the scope reduced.
Change Type
Is this a breaking change?
How did you test this PR?
Sample configuration:
Does this PR include user facing changes?
Checklist
make check-allis a good command to run locally. This check isdefined here. Some of these
checks might not be relevant to your PR. For Rust changes, at the very least you should run:
cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo nextest run --workspace(alternatively, you can runcargo test --all)Cargo.lock), pleaserun
dd-rust-license-tool writeto regenerate the license inventory and commit the changes (if any). More details here.References