Skip to content

chore(dev): prevent panic in debug+IDE builds#23668

Merged
pront merged 1 commit into
masterfrom
pront-ide-panic-fix
Aug 28, 2025
Merged

chore(dev): prevent panic in debug+IDE builds#23668
pront merged 1 commit into
masterfrom
pront-ide-panic-fix

Conversation

@pront
Copy link
Copy Markdown
Member

@pront pront commented Aug 28, 2025

Summary

This change affects debug builds only.
Stumbled upon this panic when debugging with RustRover.

Vector configuration

How did you test this PR?

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

@pront pront requested a review from a team as a code owner August 28, 2025 18:41
@github-actions github-actions Bot added the domain: core Anything related to core crates i.e. vector-core, core-common, etc label Aug 28, 2025
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Aug 28, 2025
@pront pront enabled auto-merge August 28, 2025 18:42
@pront pront added this pull request to the merge queue Aug 28, 2025
Merged via the queue into master with commit 44551f5 Aug 28, 2025
110 of 111 checks passed
@pront pront deleted the pront-ide-panic-fix branch August 28, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: core Anything related to core crates i.e. vector-core, core-common, etc no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants