feat(enrichment tables): add network CIDR field to lookup results#24576
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
network CIDR field to lookup resultsnetwork CIDR field to lookup results
|
Hello, I've completed the necessary information and code fixes, so please check it out. |
|
Hello, |
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
pront
left a comment
There was a problem hiding this comment.
Thank you. Looks good. Please address the merge conflicts.
e09c769 to
1501fce
Compare
|
Thank you for your reply. |
Summary
Add a
networkfield (CIDR notation) to GeoIP enrichment table lookup results.The MaxMind MMDB lookup API (
LookupResult) holds the network (CIDR) information for a given IP address, but the previous implementation only calleddecode()and discarded it. This PR adds thenetworkfield to all supported database types, bringing the output closer to parity with Elasticsearch's GeoIP processor.2.125.160.216/29208.192.0.0/102600:7000::/24201.243.200.0/24101.99.92.179/32Vector configuration
How did you test this PR?
cargo test -p vector --lib enrichment_tables::geoip— 12/12 passedcargo test -p vector --lib enrichment_tables::mmdb— 5/5 passed (no impact)cargo clippy— no warningscargo fmt --check— no formatting diff in changed codeChange Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
ipnetworkis a transitive dependency ofmaxminddb; onlyto_string()is used).