enhancement(kafka sink): Add support for traces in kafka sink#24639
enhancement(kafka sink): Add support for traces in kafka sink#24639pront merged 10 commits intovectordotdev:masterfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
f97a7e8 to
7213f9f
Compare
|
I have read the CLA Document and I hereby sign the CLA |
|
Thanks for the fix. I've tested this code locally by sending OTel data through a Vector ingress into Kafka and out using a Vector egress into Grafana Tempo and can confirm it works. |
|
Awesome fix any chance we could get a review on this? Have to build from source until then for my use case... |
|
@pront @rtrieu @thomasqueirozb Can someone from the maintainers team have a look? |
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
c9dfa72 to
b757d0f
Compare
Head branch was pushed to by a user without write access
0f2e6fe to
09c5a15
Compare
Summary
Add support for traces for kafka sink.
Vector configuration
Wrote and ran integration tests.
How did you test this PR?
Added integration test, traces are supported in the kafka source so sink shouldn't be problematic in any way
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References