Skip to content

enhancement(kafka sink): Add support for traces in kafka sink#24639

Merged
pront merged 10 commits intovectordotdev:masterfrom
Azyrys:add-support-for-traces-in-kafka-sink
Mar 20, 2026
Merged

enhancement(kafka sink): Add support for traces in kafka sink#24639
pront merged 10 commits intovectordotdev:masterfrom
Azyrys:add-support-for-traces-in-kafka-sink

Conversation

@Azyrys
Copy link
Contributor

@Azyrys Azyrys commented Feb 11, 2026

Summary

Add support for traces for kafka sink.

Vector configuration

Wrote and ran integration tests.

How did you test this PR?

Added integration test, traces are supported in the kafka source so sink shouldn't be problematic in any way

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

@Azyrys Azyrys requested a review from a team as a code owner February 11, 2026 13:31
@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Feb 11, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Azyrys Azyrys force-pushed the add-support-for-traces-in-kafka-sink branch from f97a7e8 to 7213f9f Compare February 11, 2026 13:39
@Azyrys
Copy link
Contributor Author

Azyrys commented Feb 11, 2026

I have read the CLA Document and I hereby sign the CLA

@elohmeier
Copy link
Contributor

elohmeier commented Mar 3, 2026

Thanks for the fix. I've tested this code locally by sending OTel data through a Vector ingress into Kafka and out using a Vector egress into Grafana Tempo and can confirm it works.

@zbirenbaum
Copy link

Awesome fix any chance we could get a review on this? Have to build from source until then for my use case...

@Azyrys
Copy link
Contributor Author

Azyrys commented Mar 10, 2026

@pront @rtrieu @thomasqueirozb Can someone from the maintainers team have a look?

@pront
Copy link
Member

pront commented Mar 19, 2026

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Azyrys Azyrys force-pushed the add-support-for-traces-in-kafka-sink branch from c9dfa72 to b757d0f Compare March 19, 2026 14:47
@pront pront enabled auto-merge March 19, 2026 14:56
auto-merge was automatically disabled March 20, 2026 11:19

Head branch was pushed to by a user without write access

Made-with: Cursor
@Azyrys Azyrys force-pushed the add-support-for-traces-in-kafka-sink branch from 0f2e6fe to 09c5a15 Compare March 20, 2026 11:21
@pront pront enabled auto-merge March 20, 2026 19:49
@pront pront added this pull request to the merge queue Mar 20, 2026
Merged via the queue into vectordotdev:master with commit 2c334d2 Mar 20, 2026
57 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: sinks Anything related to the Vector's sinks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kafka sink should support Trace output

4 participants