chore(datadog_metrics sink): switch to v2 endpoint by vladimir-dd · Pull Request #24842 · vectordotdev/vector

vladimir-dd · 2026-03-04T12:39:37Z

This PR switches the Datadog metrics sink to use the v2 series endpoint by default, automatically caps the batcher per endpoint to fix a memory issue and improve throughput, and adds a statsd_to_datadog_metrics(highload metrics-only pipeline) regression test (run).

Memory: Though this problem existed before on v1, the switch to v2's smaller payload limit (5 MiB vs 60 MiB) lowers the threshold at which unbounded batching causes memory pressure
to much lower loads. The fix automatically caps the batcher to each endpoint's payload limit so batches never need splitting, improving memory efficiency for both v1 and v2. Full benchmark results: #24874.

Throughput improvement after the memory fix detected by the regression tests:

Regression tests before the fix(switching from v1 to v2) showed no difference.

Correctness: End-to-end validated against the real DataDog API (#24879) — all metric types (counter, gauge, set, distribution, aggregated histogram, aggregated summary) pass for both v1 and v2. v1 and v2 produce identical aggregated values.

pront

Leaving some early feedback, this looks good overall.

It would be interesting to run some stress tests, it would be interesting to compare against v1.

There's an existing regression experiment here:

https://github.com/search?q=repo%3Avectordotdev%2Fvector+path%3A%2F%5Eregression%5C%2F%2F+datadog_metrics&type=code

datadog-vectordotdev · 2026-03-04T15:04:33Z

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: f64f245 | Docs | Was this helpful? Give us feedback!}

vladimir-dd · 2026-03-04T15:06:21Z

Leaving some early feedback, this looks good overall.

It would be interesting to run some stress tests, it would be interesting to compare against v1.

There's an existing regression experiment here:

https://github.com/search?q=repo%3Avectordotdev%2Fvector+path%3A%2F%5Eregression%5C%2F%2F+datadog_metrics&type=code

thanks, was about to ask for some guidance for performance testing here 🙏

Add regression test to validate datadog_metrics sink v2 endpoint performance under realistic high-throughput DogStatsD load. Test Configuration: - Load: Default lading dogstatsd settings (realistic ~2KB messages) - Throughput: 500 Mb/s → ~250k events/sec - Batch: Default settings (100k max_events, 2s timeout) - Validates batch splitting when payloads exceed v2 size limits This test ensures v2 endpoint correctly handles batch splitting with realistic high-cardinality DogStatsD metrics under load. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Different series endpoints have different uncompressed payload limits (v2 is 12x smaller than v1). This ensures each batch fits in a single HTTP request without splitting, reducing memory overhead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

pront · 2026-03-06T15:05:36Z

Note: will unsubscribe from this PR until it's "ready for review". When it's ready, we will prioritize reviewing it over other PRs.

… config - Remove references to DatadogMetricsCompression and request_compression from encoder.rs tests (those symbols don't exist in current codebase; they belong to an unmerged compression-options branch) - Fix batcher_user_max_bytes_is_preserved test to avoid struct update syntax with private PhantomData fields in BatchConfig Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…TRICS_SERIES_V2_API env var The old opt-in env var is now a no-op since v2 is the default. Emit a one-time warning so existing users know they can safely remove it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ecf75526a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

… and Sketches Series v2 has a 5 MiB uncompressed payload limit while Sketches allows 60 MiB. Previously both used the same (Series-derived) cap, which over-fragmented sketch-heavy workloads into many small requests. To support per-partition batch configuration, `PartitionedBatcher` now passes the partition key to the batch config factory closure (`Fn(&Key) -> C` instead of `Fn() -> C`). The explicit `timeout: Duration` parameter replaces the previous extraction via `settings().timeout()`. All existing callers are updated mechanically. The `datadog_metrics` sink uses the new capability to select the appropriate byte size limit per endpoint partition, keeping Series at 5 MiB and Sketches at 60 MiB. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…refactor - Add `Batch = B` constraint to `with_timer` test constructor so the compiler can infer `B` from the batch config type - Replace `Box::new(move |_| ...)` with unboxed `move |_: &u8| ...` in tests to avoid HRTB inference issues with `Fn(&Key) -> C` - Run `make fmt` to fix formatting in several sink files Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

pront

The implementation looks good to me. I left a comment about a pre-existing issue, interesting to hear your thoughts.

pront

Thanks, excited about this change.

…zation strips interval_ms `into_absolute()` always sets `interval_ms: None`, so the encoded interval for gauges is always 0. The test expectation of 10 was dead code until v2 became the default endpoint. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

pront

Check failed: https://github.com/vectordotdev/vector/actions/runs/23143552898/job/67226322004

We need to update the DD metrics E2E tests: https://github.com/vectordotdev/vector/blob/master/tests/e2e/datadog-metrics/config/test.yaml#L14

I would add series_api_version: ['v1', 'v2'] entry to the matrix above.

pront · 2026-03-17T17:09:14Z

@codex review

chatgpt-codex-connector · 2026-03-17T17:15:09Z

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…in e2e tests - Add series_api_version matrix dimension ['v1', 'v2'] to test.yaml, expanding coverage from 3 to 6 environments - Pass CONFIG_SERIES_API_VERSION through docker compose environment to the Vector container - Parameterize series_api_version in vector.toml from the env var - Refactor series::validate() to dispatch to v1 or v2 fetch function based on CONFIG_SERIES_API_VERSION - Extract assertions into compare_intakes() helper (no new assertion logic) - Replace blocking std::thread::sleep with async tokio::time::sleep in the test entry point Rationale: Vector now supports configurable series_api_version (v1/v2) in the datadog_metrics sink. The e2e test previously hardcoded v1 for the vector pipeline. This change runs the same assertions against both API versions via the CI matrix, ensuring correctness is validated for each version independently without duplicating test logic.

pront · 2026-03-17T18:16:54Z

LGTM - feel free to enqueue whenever you want

vladimir-dd requested a review from a team as a code owner March 4, 2026 12:39

github-actions Bot added the domain: sinks Anything related to the Vector's sinks label Mar 4, 2026

vladimir-dd changed the title ~~Switch to Datadog Metrics v2 endpoint~~ chore(datadog_metrics sink): Re-enable v2 endpoint Mar 4, 2026

vladimir-dd marked this pull request as draft March 4, 2026 13:03

pront reviewed Mar 4, 2026

View reviewed changes

Comment thread src/sinks/datadog/metrics/config.rs Outdated

pront reviewed Mar 4, 2026

View reviewed changes

Comment thread src/sinks/datadog/metrics/encoder.rs Outdated

chore(datadog_metrics sink): switch to Datadog Metrics V2 endpoint

bbc657a

vladimir-dd force-pushed the vladimir-dd/metrics-v2 branch 2 times, most recently from 8148cb3 to 9bb9b2b Compare March 5, 2026 17:26

vladimir-dd force-pushed the vladimir-dd/metrics-v2 branch from 9bb9b2b to 0cb05d2 Compare March 6, 2026 06:40

github-advanced-security AI found potential problems Mar 9, 2026

View reviewed changes

Comment thread dd_metrics_v2_bench_results.md Fixed

vladimir-dd and others added 2 commits March 10, 2026 13:22

vladimir-dd force-pushed the vladimir-dd/metrics-v2 branch from 55877a4 to 8ecf755 Compare March 10, 2026 12:24

vladimir-dd marked this pull request as ready for review March 10, 2026 14:50

chatgpt-codex-connector Bot reviewed Mar 10, 2026

View reviewed changes

Comment thread src/sinks/datadog/metrics/config.rs Outdated

vladimir-dd and others added 3 commits March 10, 2026 16:00

trigger build

f72ada7

Merge branch 'master' into vladimir-dd/metrics-v2

e609e96

vladimir-dd force-pushed the vladimir-dd/metrics-v2 branch from 104855e to 365d824 Compare March 11, 2026 18:09

vladimir-dd changed the title ~~chore(datadog_metrics sink): Re-enable v2 endpoint~~ chore(datadog_metrics sink): switch to v2 endpoint Mar 11, 2026

vladimir-dd force-pushed the vladimir-dd/metrics-v2 branch from 474cced to 3988235 Compare March 11, 2026 18:57

vladimir-dd requested a review from pront March 11, 2026 19:33

pront reviewed Mar 12, 2026

View reviewed changes

Comment thread changelog.d/datadog_metrics_series_v2_default.enhancement.md Outdated

update docs

490cdee

vladimir-dd requested a review from a team as a code owner March 13, 2026 14:24

github-actions Bot added the domain: external docs Anything related to Vector's external, public documentation label Mar 13, 2026

mark v1 as deprecated

5dff55d

vladimir-dd requested a review from pront March 13, 2026 14:37

hestonhoffman previously approved these changes Mar 13, 2026

View reviewed changes

pront previously approved these changes Mar 13, 2026

View reviewed changes

vladimir-dd added this pull request to the merge queue Mar 16, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 16, 2026

vladimir-dd enabled auto-merge March 16, 2026 12:12

vladimir-dd added this pull request to the merge queue Mar 16, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 16, 2026

pront reviewed Mar 16, 2026

View reviewed changes

vladimir-dd dismissed stale reviews from pront and hestonhoffman via 08f4032 March 16, 2026 14:24

pront approved these changes Mar 17, 2026

View reviewed changes

vladimir-dd force-pushed the vladimir-dd/metrics-v2 branch from b72c6d2 to 8635670 Compare March 17, 2026 17:51

vladimir-dd force-pushed the vladimir-dd/metrics-v2 branch from 8635670 to e7b77ca Compare March 17, 2026 17:52

Merge branch 'master' into vladimir-dd/metrics-v2

f64f245

pront approved these changes Mar 17, 2026

View reviewed changes

vladimir-dd added this pull request to the merge queue Mar 17, 2026

Merged via the queue into master with commit dc9d8de Mar 17, 2026
71 checks passed

vladimir-dd deleted the vladimir-dd/metrics-v2 branch March 17, 2026 19:12

github-actions Bot locked and limited conversation to collaborators Mar 17, 2026

Conversation

vladimir-dd commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pront left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

datadog-vectordotdev Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vladimir-dd commented Mar 4, 2026

Uh oh!

Uh oh!

pront commented Mar 6, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

pront left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pront left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pront left a comment

Choose a reason for hiding this comment

Uh oh!

pront commented Mar 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented Mar 17, 2026

Uh oh!

pront commented Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vladimir-dd commented Mar 4, 2026 •

edited

Loading

datadog-vectordotdev Bot commented Mar 4, 2026 •

edited

Loading