Skip to content

fix(ci): use cross-strip tools when packaging RPMs for non-x86_64 targets#24873

Merged
thomasqueirozb merged 2 commits intomasterfrom
fix/rpm-cross-strip
Mar 9, 2026
Merged

fix(ci): use cross-strip tools when packaging RPMs for non-x86_64 targets#24873
thomasqueirozb merged 2 commits intomasterfrom
fix/rpm-cross-strip

Conversation

@thomasqueirozb
Copy link
Contributor

@thomasqueirozb thomasqueirozb commented Mar 9, 2026

Summary

After #24864 removed the Docker wrapper for RPM packaging, the host's x86_64 strip tool is used during rpmbuild's brp-strip post-install phase. This fails for cross-compiled binaries (armv7, aarch64) since strip can't recognize a different architecture's ELF format.

Fix by installing binutils-arm-linux-gnueabihf and binutils-aarch64-linux-gnu on the runner, and passing the appropriate cross-strip binary to rpmbuild via --define "__strip ..." in package-rpm.sh.

Vector configuration

NA

How did you test this PR?

Triggered a new nightly run from this branch: https://github.com/vectordotdev/vector/actions/runs/22868431384/job/66341531846

Change Type

  • Bug fix
  • New feature
  • Dependencies
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

@github-actions github-actions bot added domain: ci Anything related to Vector's CI environment domain: releasing Anything related to releasing Vector labels Mar 9, 2026
@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Mar 9, 2026
@thomasqueirozb thomasqueirozb marked this pull request as ready for review March 9, 2026 17:58
@thomasqueirozb thomasqueirozb requested a review from a team as a code owner March 9, 2026 17:58
@thomasqueirozb thomasqueirozb added this pull request to the merge queue Mar 9, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 9, 2026
@thomasqueirozb thomasqueirozb added this pull request to the merge queue Mar 9, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 9, 2026
@thomasqueirozb thomasqueirozb added this pull request to the merge queue Mar 9, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 9, 2026
@thomasqueirozb thomasqueirozb added this pull request to the merge queue Mar 9, 2026
Merged via the queue into master with commit 3f98053 Mar 9, 2026
96 checks passed
@thomasqueirozb thomasqueirozb deleted the fix/rpm-cross-strip branch March 9, 2026 22:28
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: ci Anything related to Vector's CI environment domain: releasing Anything related to releasing Vector no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants