Conversation
pront
changed the title
pront
changed the title
…on tracing is off Add GetAllocationTracingStatus gRPC endpoint that reports whether the connected Vector instance has --allocation-tracing active. vector-top queries this on startup and shows "disabled" in the Memory Used column when tracing is off, instead of misleading zeros. Changes: - proto: add GetAllocationTracingStatus RPC and messages - service.rs: implement the endpoint using is_allocation_tracing_enabled() - client.rs: add get_allocation_tracing_status() method - metrics.rs: query the endpoint on startup, store result in State - state.rs: add allocation_tracing_active field to State - dashboard.rs: show "disabled" when allocation_tracing_active is false Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pront
force-pushed
the
pavlos/vector-top-inactive-memory-label
branch
from
f61072b to
010b9d3
Compare
pront
changed the title
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea36843feb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pront
changed the title
The `get_allocation_tracing_status` RPC handler unconditionally called `is_allocation_tracing_enabled()`, which only exists behind the `allocation-tracing` feature gate. This broke builds on feature sets that lack it (e.g. `default-msvc`). Add cfg guards so the handler returns `false` when the feature is absent. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
thomasqueirozb
approved these changes
Apr 7, 2026
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29782252a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
GetAllocationTracingStatusgRPC endpoint that reports whether the connected Vector instance has--allocation-tracingactive.vector topqueries this on startup ( or when reconnecting) and showsdisabledin theMemory Usedcolumn when tracing is off, instead of misleading zeros.Motivation: This is part of a series of
vector topUI improvements:Previously, when
--allocation-tracingwas not passed, the Memory Used column showed "0 B" for all components with no indication that the feature was simply not enabled.Changes
GetAllocationTracingStatusRPC and messages toobservability.protois_allocation_tracing_enabled()get_allocation_tracing_status()client methodStateallocation_tracing_activefield toStateallocation_tracing_activeis falseVector configuration
Any config works. Compare:
cargo run -- -c <config.yml>thenvector top(shows "disabled")cargo run -- -c <config.yml> --allocation-tracingthenvector top(shows actual bytes)How did you test this PR?
vector topwith and without--allocation-tracingmake check-clippyandmake check-fmtpassChange Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
🤖 Generated with Claude Code