Skip to content

fix(website): fix docs sidebar expand/collapse navigation#25238

Merged
pront merged 2 commits intovectordotdev:masterfrom
shalk:fix-sidebar-nav
Apr 22, 2026
Merged

fix(website): fix docs sidebar expand/collapse navigation#25238
pront merged 2 commits intovectordotdev:masterfrom
shalk:fix-sidebar-nav

Conversation

@shalk
Copy link
Copy Markdown
Contributor

@shalk shalk commented Apr 22, 2026

Summary

  • Use strings.HasPrefix to keep sections expanded when on any child page (the previous eq check only matched the section index, not child pages)
  • Add @click="open = true" to section title links so clicking the title expands the group in addition to navigating, without requiring the chevron

Vector configuration

How did you test this PR?

Change Type

  • Bug fix
  • New feature
  • Dependencies
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.

- Use strings.HasPrefix to keep sections expanded when on any child page
  (the previous eq check only matched the section index, not child pages)
- Add @click="open = true" to section title links so clicking the title
  expands the group in addition to navigating, without requiring the chevron

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@shalk shalk requested review from a team as code owners April 22, 2026 09:05
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@shalk
Copy link
Copy Markdown
Contributor Author

shalk commented Apr 22, 2026

recheck

@shalk
Copy link
Copy Markdown
Contributor Author

shalk commented Apr 22, 2026

I have read the CLA Document and I hereby sign the CLA

@shalk
Copy link
Copy Markdown
Contributor Author

shalk commented Apr 22, 2026

recheck

@pront pront added no-changelog Changes in this PR do not need user-facing explanations in the release changelog domain: website labels Apr 22, 2026
Copy link
Copy Markdown
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great enhancement, thanks

@pront pront enabled auto-merge April 22, 2026 20:40
@pront pront added this pull request to the merge queue Apr 22, 2026
Merged via the queue into vectordotdev:master with commit d99899e Apr 22, 2026
77 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: website no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants