fix(tests): fix flaky initial_size_correct_with_multievents test#25239
Conversation
thomasqueirozb
added
the
no-changelog
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50e0f3ee71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
vparfonov
force-pushed
the
fix-flaky-ledger-lock-test
branch
from
50e0f3e to
d9e0ceb
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9e0ceb076
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
vparfonov
force-pushed
the
fix-flaky-ledger-lock-test
branch
from
d9e0ceb to
e445cf9
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e445cf9faf
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
vparfonov
force-pushed
the
fix-flaky-ledger-lock-test
branch
from
e445cf9 to
e55d500
Compare
pront
left a comment
pront
left a comment
There was a problem hiding this comment.
Thanks, this iteration makes sense to me.
Manually construct a write-only `BufferWriter` and `Ledger` during the test setup instead of using `create_default_buffer_v2`. This prevents spawning a detached background finalizer task, ensuring the `Arc<Ledger>` and file lock are released synchronously and deterministically when dropped.
vparfonov
force-pushed
the
fix-flaky-ledger-lock-test
branch
from
e55d500 to
ecf643f
Compare
Head branch was pushed to by a user without write access
3 participants
Summary
Replace the one-shot
create_default_buffer_v2_with_usagecall with retry loop when reopening the buffer. After dropping the first buffer, the background finalizer task may still hold anArc<Ledger>(and thus the lock file). The retry loop only retries onLedgerLockAlreadyHelderrors — any other error panics immediately to avoid masking real failures. The test framework's own timeout handles truly stuck cases.Also removes the now-unused
create_default_buffer_v2_with_usagehelper.Vector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.