Skip to content

fix(ci): make publish-s3 wait for generate-sha256sum#25265

Merged
pront merged 1 commit intomasterfrom
fix/publish-s3-wait-for-sha256sum
Apr 27, 2026
Merged

fix(ci): make publish-s3 wait for generate-sha256sum#25265
pront merged 1 commit intomasterfrom
fix/publish-s3-wait-for-sha256sum

Conversation

@thomasqueirozb
Copy link
Copy Markdown
Contributor

@thomasqueirozb thomasqueirozb commented Apr 24, 2026

Summary

The publish-s3 job uploads release artifacts to packages.timber.io but does not currently depend on generate-sha256sum, which produces vector-<ver>-SHA256SUMS. As a result, publish-s3 can finish before the checksum file is generated, so downstream consumers that expect SHA256SUMS under packages.timber.io/vector/<ver>/ (e.g. install.sh verification, post-release verification tooling) can race the workflow.

Fix by adding generate-sha256sum to publish-s3's needs: list. publish-github already has this dependency.

This is a small/rare race condition.

Vector configuration

NA

How did you test this PR?

NA

Change Type

  • Bug fix
  • New feature
  • Dependencies
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

NA

@github-actions github-actions Bot added the domain: ci Anything related to Vector's CI environment label Apr 24, 2026
@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Apr 24, 2026
@thomasqueirozb thomasqueirozb marked this pull request as ready for review April 24, 2026 21:44
@thomasqueirozb thomasqueirozb requested a review from a team as a code owner April 24, 2026 21:44
@pront pront added this pull request to the merge queue Apr 27, 2026
Merged via the queue into master with commit 61cc4d8 Apr 27, 2026
83 of 84 checks passed
@pront pront deleted the fix/publish-s3-wait-for-sha256sum branch April 27, 2026 13:42
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: ci Anything related to Vector's CI environment no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants