Skip to content

enhancement(metrics): Add remove tag function for metrics which returns entire tag set#25361

Open
ArunPiduguDD wants to merge 1 commit intomasterfrom
add-remove-tag-set-function-metrics
Open

enhancement(metrics): Add remove tag function for metrics which returns entire tag set#25361
ArunPiduguDD wants to merge 1 commit intomasterfrom
add-remove-tag-set-function-metrics

Conversation

@ArunPiduguDD
Copy link
Copy Markdown
Contributor

Summary

Add a helper function to remove a tag in a metric and return the entire associated tag set (current remove function only returns a single tag)

How did you test this PR?

Added unit tests

Change Type

  • Bug fix
  • New feature
  • Dependencies
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.

@ArunPiduguDD ArunPiduguDD requested a review from a team as a code owner May 4, 2026 20:58
@github-actions github-actions Bot added the domain: core Anything related to core crates i.e. vector-core, core-common, etc label May 4, 2026
@ArunPiduguDD ArunPiduguDD changed the title enhancement(metrics): Add remove tag function for metrics which retur… enhancement(metrics): Add remove tag function for metrics which returns entire tag set May 4, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 64e8f65150

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/vector-core/src/event/metric/tags.rs Outdated
@ArunPiduguDD ArunPiduguDD added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label May 4, 2026
@ArunPiduguDD ArunPiduguDD force-pushed the add-remove-tag-set-function-metrics branch from 64e8f65 to e6fe25e Compare May 4, 2026 21:05
@ArunPiduguDD ArunPiduguDD force-pushed the add-remove-tag-set-function-metrics branch from e6fe25e to 955df49 Compare May 4, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: core Anything related to core crates i.e. vector-core, core-common, etc no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants