chore(unit tests): failing disk_v2 bug demonstrations#25525
Draft
blt wants to merge 1 commit into
Draft
Conversation
This was referenced May 29, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9 tasks
1ceda6a to
b0a9285
Compare
579bdea to
3bb6d14
Compare
|
3bb6d14 to
7ce6082
Compare
b0a9285 to
340ba97
Compare
Seven tests that assert the CORRECT invariant and therefore FAIL against current Vector, each reproducing a real disk_v2 data-loss / accounting bug: #24606 (component drop metric), #21683 (total_buffer_size decrement underflow), get_total_records 0-1 underflow, #24948 (writer drop loses buffered events), finalizer status-discard (rejected delivery acked), reader.rs:932 file-id rollover, reader.rs:524 size-delta underflow. Runnable with plain cargo test -p vector-buffers.
7ce6082 to
84f01cb
Compare
340ba97 to
7c97a68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Seven
vector-bufferstests that assert the correct invariant and thereforefail against current Vector, each reproducing a real disk buffer v2 data-loss
or accounting defect. The failures are the demonstration — CI on this PR is
expected to be red on these tests until the underlying bugs are fixed.
drop_newest_drops_should_increment_component_discarded_metric_issue_24606component_discarded_events_totalledger_total_buffer_size_decrement_should_saturate_not_underflow_issue_21683get_total_records_should_be_zero_on_drained_buffer_issue_21683_metricsget_total_records0-1 underflow on a drained bufferwriter_drop_without_flush_should_not_lose_buffered_events_issue_24948Dropwithout flush loses buffered eventsrejected_delivery_should_not_advance_acks_finalizer_status_discardBatchStatus; a rejected delivery still advances acksfile_id_rollover_compare_should_be_wrap_aware_reader_932reader.rs:932file-id comparison not wrap-awaredelete_completed_data_file_size_delta_should_saturate_reader_524reader.rs:524metadata.len() - bytes_readunderflowHow did you test this PR?
cargo nextest run -p vector-buffers→ exactly these 7 fail (78 pass), each for thedocumented reason. Independent of the rest of the stack (no Antithesis deps needed).
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References