chore(vdev): add --features flag and FEATURES env var support to build/check/test commands#25688
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d0febc2b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94bf42ceea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Let's wait for #25690 which should simplify this PR. |
07c329c to
3bdbdc0
Compare
3bdbdc0 to
8fc5af0
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41e6976b95
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
All vdev commands that shell out to cargo with a feature set (
check rust,build,test,crate_versions) previously accepted features as positional arguments or used an inconsistent--feature(singular) flag. This makes them non-obvious and inconsistent with cargo's own interface.This PR:
featuresargument incheck rustwith a named--featuresflag (short:-F, comma-separated)--feature→--featuresinbuild vectorandcrate_versions--featuresflag totest(replacing the implicit passthrough hack)--no-default-featurestocheck rustandtestenv = "FEATURES"on all--featuresflags soFEATURES=x,y make check-clippynow worksBefore:
After:
cargo vdev check rust --features default,rdkafka-dynamic FEATURES=default,rdkafka-dynamic make check-clippy # worksVector configuration
N/A — vdev tooling change only.
How did you test this PR?
cargo build -p vdevcompiles cleanlycargo vdev check rust --all-featuressuccessfully--helpoutput oncheck rust,build,testChange Type
Is this a breaking change?
cargo vdev check rust <feature> <feature>(positional) no longer works. Replacement:cargo vdev check rust --features feat1,feat2.Does this PR include user facing changes?
no-changeloglabel to this PR.References