test(recall): stop passing removed semantic_seeds into link expansion#2829
Merged
Conversation
#2683 removed the graph seed inputs from LinkExpansionRetriever.retrieve() — Link Expansion deliberately chooses its own bounded seeds so it doesn't inherit the semantic arm's limits and thresholds. The scoring regression test from #2679 still passed semantic_seeds=, so it fails on main with TypeError: retrieve() got an unexpected keyword argument 'semantic_seeds' on every PR whose test-api shard includes it. Drop the kwarg and stub the internal _find_semantic_seeds lookup instead, which is where seeds now come from. The test's subject — that the graph merge order matches Link Expansion's additive per-type score — and all of its assertions are unchanged. The skills/hindsight-docs hunk is generated output from an unrelated docs PR that landed without regenerating the bundle; the pre-commit generator requires it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
test-api (2/3)failure currently red onmainand therefore on every PR whose shard includes this test:#2683 ("remove unused graph seed inputs") dropped
semantic_seedsfromretrieve()— Link Expansion deliberately chooses its own bounded seeds, so it doesn't inherit the semantic arm's independent limits and thresholds. The scoring regression test added by #2679 still passed the kwarg.Fix
Per direction from the code owner:
semantic_seedsshould not be used anymore, so the test is updated rather than the signature restored.Removing the kwarg alone isn't sufficient —
retrieve()now derives seeds internally via_find_semantic_seeds(conn, ...), and the test's fake connection is a bareobject()with nofetch. So the fix stubs that lookup to return the same seed the test previously injected:The test's subject — that graph merge order matches Link Expansion's additive per-type score — and every assertion are unchanged:
Testing
tests/test_link_expansion_scoring.py— 1 passed.ruff check/ruff formatclean.The
skills/hindsight-docs/**hunks are generated output from unrelated docs/integration PRs that landed without regenerating the bundle; the pre-commit generator refuses to commit without them.