fix(retain): sync metadata to unchanged memories - #3011
Merged
nicoloboschi merged 1 commit intoAug 4, 2026
Merged
Conversation
Keep metadata and tags on unchanged memory units aligned with their document during delta retain. Cover metadata-only replace and append paths with regression tests. Closes vectorize-io#3008
Sanderhoff-alt
marked this pull request as ready for review
July 28, 2026 08:10
nicoloboschi
approved these changes
Aug 4, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep metadata on memory units aligned with
document_metadatawhen delta retain preserves unchanged chunks.Closes #3008.
Root cause
Delta retain already updated the document row and propagated tags to existing memory units. It did not propagate metadata, so preserved memories kept the previous value while rebuilt or newly inserted memories used the current retain metadata.
unchangedchangednewremovedImplementation
Impact
After retain completes, every surviving direct memory unit for the document has metadata consistent with
document_metadata, regardless of whether delta retain preserved or rebuilt its chunk.The change adds no schema migration, JSON-specific branch, or extra database round trip.
Validation
git diff --check