fix(ai): unify generate text event callbacks - #14762
Merged
Merged
Conversation
lgrammel
marked this pull request as ready for review
April 27, 2026 17:35
lgrammel
marked this pull request as draft
April 27, 2026 17:36
lgrammel
marked this pull request as ready for review
April 27, 2026 17:43
aayush-kapoor
approved these changes
Apr 27, 2026
lgrammel
enabled auto-merge (squash)
April 27, 2026 17:45
gr2m
pushed a commit
that referenced
this pull request
Jun 5, 2026
## Background The start, end, step start, step end callback were duplicated in `ToolLoopAgent`, `generateText`, `streamText`. This duplication is unnecessary and leads to a risk of type shifts and subsequent typechecking issues. ## Summary * unify the callbacks into `GenerateText*` callbacks * rename `core-events.ts` to `generate-text-events.ts` * move the callbacks into `generate-text-events.ts`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The start, end, step start, step end callback were duplicated in
ToolLoopAgent,generateText,streamText.This duplication is unnecessary and leads to a risk of type shifts and subsequent typechecking issues.
Summary
GenerateText*callbackscore-events.tstogenerate-text-events.tsgenerate-text-events.ts