fix(harness): guard against invalid resuming a session vs continuing a turn - #16047
Merged
Conversation
…rrect-resume-vs-continue
gr2m
approved these changes
Jun 12, 2026
Contributor
|
🚀 Published in:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves/fixes a few related harness issues:
HarnessAgenthad acontinueTurnthat was returning aStreamTextResult, but it missed the corresponding equivalent that returns aGenerateTextResult. This PR replaces the method withcontinueStreamandcontinueGenerate.suspendTurn).HarnessAgentnow more cleanly separates "resume session state" and "continue turn state", with only the latter being able to continue pending tool approvals (because by definition tool approval requests lead to an interrupted turn).HarnessAgentnow guards against incorrect method invocation: when a session is resumed with state that indicates that there's a mid-flight turn, callingstreamorgeneratewill error. Accordingly, if the resume state indicates there is no mid-flight turn, callingcontinueStreamorcontinueGeneratewill error.Manual Verification
Run the existing examples.
Checklist
pnpm changesetin the project root)