fix: send OpenAI chat image data as data URLs - #16655
Merged
Merged
Conversation
gr2m
changed the title
gr2m
marked this pull request as ready for review
July 5, 2026 19:27
gr2m
added
the
backport
github-actions
Bot
removed
the
backport
Contributor
|
|
Contributor
gr2m
added a commit
that referenced
this pull request
Jul 6, 2026
v6 already encodes inline image data as data URLs with its own data model,
so the incoming changes were redundant/incompatible. Kept the v6 implementation
and existing v6 tests; dropped the main-only Uint8Array test and the
top-level-only media type resolution describe block (both rely on the
resolveFullMediaType helper and {type:'data'} data model absent in v6).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
OpenAI chat image parts with inline binary data were sent as bare base64 strings, which are not valid image URLs.
Summary
Encode inline image file parts as
data:<media-type>;base64,...URLs when converting messages for OpenAI chat requests.Manual Verification
Covered by the updated OpenAI chat message conversion tests.
Checklist
pnpm changesetin the project root)Related Issues
Fixes #16654