fix(provider-utils): pass each redirect hop an independent header snapshot - #17169
Merged
gr2m merged 2 commits intoJul 13, 2026
Merged
Conversation
…pshot fetchWithValidatedRedirects reused one Headers instance across hops and mutated it in place for the cross-origin credential drop. The platform fetch reads headers synchronously so behavior was correct, but an injected custom fetch that defers reading could observe post-mutation state, and mock-based tests asserting on an earlier hop would silently see later mutations. Clone the header set per hop instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
dnukumamras
approved these changes
Jul 13, 2026
…per-hop-header-snapshot
gr2m
merged commit Jul 13, 2026
ab60433
into
dnukumamras/getfromapi-url-validation
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Follow-up to the review of #16971.
fetchWithValidatedRedirectspassed the same mutableHeadersinstance to every hop'sfetchcall and mutated it in place for the cross-origin credential drop. Realfetchimplementations snapshot headers synchronously at call time, so observable behavior was correct — but:init.headerscould observe post-mutation state, i.e. a first-hop request whose credentials appear already dropped or vice versa;mock.calls[0][1].headersandmock.calls[1][1].headerswere the same object, so any future assertion on an earlier hop's headers would silently check later-hop state.Each hop now gets its own
new Headers(currentHeaders)snapshot. Includes a regression test asserting the hops receive distinct objects and that the cross-origin drop is not retroactively visible on the first hop.