fix: align ToolLoopAgent prepareCall types with runtime-supported settings - #18522
Open
ai-sdk-factory[bot] wants to merge 2 commits into
Open
fix: align ToolLoopAgent prepareCall types with runtime-supported settings#18522ai-sdk-factory[bot] wants to merge 2 commits into
ai-sdk-factory[bot] wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Valid ToolLoopAgent prepareCall code failed TypeScript checks for runtime-supported settings and advertised call-only fields that are never provided.
Root Cause
The prepareCall input and return types used incomplete Pick lists and an insufficient Omit list. The reproduction confirmed the omitted settings were available and honored at runtime while TypeScript rejected them, and that advertised call-only fields were stripped before invocation.
Summary
Added toolChoice, maxRetries, prepareStep, repairToolCall, and experimental_repairToolCall to prepareCall input and return types; removed unavailable call-only fields from its input type; added an ai patch changeset.
Testing
Added type regression coverage for all newly exposed settings and for exclusion of fields absent at runtime.
End-to-end Validation
pnpm -C packages/ai buildfollowed by an in-memory TypeScript consumer compile against the generated declarations passed with the supported overrides and rejected-field assertions.Related Issues
Fixes #18518
Closes #18520