fix(WorkflowAgent): apply maxRetries and abortSignal from prepareCall - #18593
Open
edenbuilds wants to merge 1 commit into
Open
fix(WorkflowAgent): apply maxRetries and abortSignal from prepareCall#18593edenbuilds wants to merge 1 commit into
edenbuilds wants to merge 1 commit into
Conversation
prepareCall could return these GenerationSettings fields, but the field-by-field merge skipped them so they were silently dropped (vercel#18576).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkflowAgent.prepareCallcan returnmaxRetriesandabortSignal(they are onGenerationSettings/PrepareCallResult), but the field-by-field merge skipped both so they were silently dropped.effectiveGenerationSettingsthe same way asseed/headers.streamTextIterator'sgenerationSettings.Fixes #18576
Test plan
pnpm test:node -- src/workflow-agent.test.tsinpackages/workflow(includes new prepareCall coverage)maxRetries/abortSignalstill override prepareCall via the existing merge orderMade with Cursor