feat(eve): handle authorized approvals in Slack - #1349
Closed
benpankow wants to merge 1 commit into
Closed
Conversation
Signed-off-by: benpankow <ben.pankow@vercel.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| return undefined; | ||
| } | ||
|
|
||
| function buildPendingApprovalCards( |
Contributor
There was a problem hiding this comment.
Non-approval HITL responses (select / radio_buttons / static_select) are stored in pendingApprovalCards but never consumed, causing an unbounded durable-state leak.
Collaborator
Author
|
Superseded by the consolidated 7-PR implementation stack starting at #1368 (GitHub stack #1375). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Slack as the foreground authorized-approval client:
approval.settledand preserves sibling controlsauthorization.requireddelivery pathValidation
pnpm --filter eve exec vitest run --config vitest.unit.config.ts src/channel/send.test.ts src/public/channels/slack/defaults.test.ts src/public/channels/slack/slackChannel.test.ts src/public/channels/slack/interactions.test.tspnpm --filter eve typecheckStack
Depends on #1348.