refactor(eve): represent pending input as assistant-turn batches - #1737
Open
ruiconti wants to merge 3 commits into
Open
refactor(eve): represent pending input as assistant-turn batches#1737ruiconti wants to merge 3 commits into
ruiconti wants to merge 3 commits into
Conversation
Signed-off-by: Rui Conti <ruiconti@gmail.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: Rui Conti <ruiconti@gmail.com>
Signed-off-by: Rui Conti <ruiconti@gmail.com>
ruiconti
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the singleton pending-input batch with an ordered list of assistant-turn input batches. A batch contains the requests created by one assistant turn and stores that turn's model output once. A batch containing only approvals is an assistant-turn approval batch.
Resolution still reads and removes only the oldest batch, so behavior stays unchanged. Duplicate request IDs fail instead of overwriting; all open IDs remain visible across batches; v1 durable snapshots migrate into one v2 batch.
Data flow
Before: each
setPendingInputBatchreplaced the one pending batch.After: each call appends one assistant-turn input batch. Existing resolver code reads the oldest batch through the same API and leaves later batches untouched.
Why this shape
The model output is shared by requests created in the same assistant turn and must be restored exactly once. A simple ordered batch list represents that directly. There is no separate store and no normalized request↔batch index.
Scope
Data-only stage stacked on #1727. Required/dismissable behavior, deferred messages, stale handling, routing, and protocol events do not change.