Skip to content

[1/3] feat(eve): add turn commit rollback hooks - #3055

Draft
benpankow wants to merge 3 commits into
mainfrom
benpankow/turn-commit-rollback
Draft

[1/3] feat(eve): add turn commit rollback hooks#3055
benpankow wants to merge 3 commits into
mainfrom
benpankow/turn-commit-rollback

Conversation

@benpankow

@benpankow benpankow commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds a policy-neutral beforeTurnCommit hook so an agent can inspect completed output and candidate history before a conversation turn's terminal response reaches the channel. Returning "rollback" restores history from before that settling turn and withholds its terminal completion; returning "commit" keeps and releases it. Tool approvals remain separate turns, so this intentionally does not model a cross-turn review transaction.

export default defineHook({
  beforeTurnCommit(candidate) {
    return hasMatchingApprovedReview(candidate.history, candidate.output)
      ? "commit"
      : "rollback";
  },
});

This is the first PR in a three-PR stack. Background-task invalidation is added in #3056, followed by private Slack approval delivery in #3061.

Validation

Adds coverage for conversation-only gating, terminal commit and rollback, stale-checkpoint replacement, clear and structured-failure cleanup, hook ordering, and malformed hook decisions. Task mode retains its existing terminal event behavior.

🤖

@vercel

vercel Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
eve-docs Ready Ready Preview Sep 4, 2026 10:55pm UTC
eve-docs-4759 Ready Ready Preview, v0 Sep 4, 2026 10:55pm UTC
eve-pkg Ready Ready Preview Sep 4, 2026 10:55pm UTC

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Bundle + Package Summary: apps/fixtures/weather-agent

Key takeaways

  • Runtime delta: public routes 18 -> 19 (+1); 1 changed payload.

Delta vs main (e603739)

Area Metric Baseline Current Delta
Package Packed tarball 8.65 MB 8.65 MB +3.5 kB ⚠️
Package Unpacked publish size 32.58 MB 32.62 MB +41.4 kB ⚠️
Package Installed footprint 77.65 MB 77.70 MB +41.4 kB ⚠️
Package Published files 3835 3845 +10
Package Installed files 7733 7743 +10
Package Installed package instances 33 33 0
Package Distinct installed package names 32 32 0
Package Installed dependency edges 51 51 0
Package Installed optional peer edges 7 7 0
Runtime Unique function payloads 2 2 0
Runtime Total function bytes 20.71 MB 20.73 MB +20.4 kB ⚠️
Runtime Public routes 18 19 +1
Changed function payloads vs main (e603739) (2)
Function Status Baseline Current Delta Route changes
functions/__server.func changed 10.36 MB 10.37 MB +10.2 kB ⚠️ public +/eve/v1/session/[sessionId]/restore-history
functions/.well-known/workflow/v1/flow.func changed 10.36 MB 10.37 MB +10.2 kB ⚠️ none

eve init install

Metric Baseline Current Delta
Installed footprint 116.09 MB 116.13 MB +41.4 kB ⚠️
Installed packages 113 113 0
dependencies 4 4 0
devDependencies 2 2 0
Dependency package bytes 48.70 MB 48.74 MB +41.4 kB ⚠️
devDependency package bytes 5.04 MB 5.04 MB 0 B ➖
Build Metadata
  • Preset: vercel
  • Nitro: nitro@3.0.260903-beta
  • Output directory: apps/fixtures/weather-agent/.vercel/output
  • Build metadata timestamp: 2026-09-04T22:56:04.168Z
  • Route aliases: 19 public, 1 internal (20 total aliases)
  • Vercel routes in config: 22
  • Severity legend: 🔴 dominant/large, 🟠 notable, 🟡 watch, ⚪ small
Package Drill-Down

Package Details

  • Package: eve@0.52.1
  • Package directory: packages/eve
  • Tarball: 8.65 MB (eve-0.52.1.tgz)
  • Unpacked payload: 32.62 MB across 3845 published files
  • Installed footprint: 77.70 MB across 7743 installed files
  • Installed root package: 31.19 MB
  • Installed dependencies: 46.51 MB
  • Installed package instances: 33
  • Distinct installed package names: 32
  • Installed dependency edges: 51
  • Installed optional peer edges: 7
  • Runtime dependencies: 2
  • Peer dependencies: 5 (4 optional)

Installed footprint is measured from an isolated temporary npm install of the packed tarball.
Graph metrics read only package.json files in package directories directly beneath a node_modules boundary, including nested boundaries. Each directory is one package instance; distinct names come from those manifests. Dependency edges count each unique name in dependencies or optionalDependencies per instance; optional peer edges count peerDependencies marked optional.

Heavy installed dependencies

  • eve: 31.19 MB (40.1%)
  • @rolldown/binding-linux-x64-gnu: 19.31 MB (24.9%)
  • ai: 7.01 MB (9.0%)
  • zod: 6.41 MB (8.3%)
  • undici: 3.51 MB (4.5%)
Publish payload breakdown
Published file size
🔴 dist/src/compiled/shadcn-registry/index.js       [#############...........] 9.76 MB 29.9%
🟠 dist/src/compiled/@photon-ai/chat-adapter-ime... [###.....................] 2.27 MB 7.0%
🟠 dist/src/compiled/@ai-sdk/code-mode/index.js     [#.......................] 1.03 MB 3.1%
🟡 dist/src/compiled/@vercel/blob/index.js          [#.......................] 901.4 kB 2.8%
🟡 dist/src/compiled/_chunks/workflow/signal-exi... [#.......................] 514.6 kB 1.6%
🔴 Other published files                            [########################] 18.15 MB 55.6%
Installed footprint breakdown
Installed package size
🔴 eve                             [########################] 31.19 MB 40.1%
🔴 @rolldown/binding-linux-x64-gnu [###############.........] 19.31 MB 24.9%
🔴 ai                              [#####...................] 7.01 MB 9.0%
🔴 zod                             [#####...................] 6.41 MB 8.3%
🟠 undici                          [###.....................] 3.51 MB 4.5%
🟠 nitro                           [#.......................] 1.89 MB 2.4%
🔴 Other installed packages        [######..................] 8.36 MB 10.8%
Runtime dependencies (2)
Package Range Notes
nitro 3.0.260903-beta
undici 8.9.0
Peer dependencies (5)
Package Range Notes
@opentelemetry/api ^1.0.0 optional peer
ai catalog:
braintrust ^3.0.0 optional peer
just-bash ^3.1.0 optional peer
microsandbox ^0.5.0 optional peer
eve init install drill-down

eve init install details

  • Command: eve init my-agent
  • Package manager: npm
  • Installed footprint: 116.13 MB across 9639 installed files
  • Installed packages: 113 total (107 transitive-only)
  • dependencies: 4 direct packages totaling 48.74 MB
  • devDependencies: 2 direct packages totaling 5.04 MB
  • Other transitive package files: 62.35 MB

Installed footprint is measured from an isolated temporary eve init my-agent using the current packed eve tarball.

Heavy installed dependencies

  • eve: 31.19 MB (26.9%)
  • @typescript/typescript-linux-x64: 27.95 MB (24.1%)
  • @rolldown/binding-linux-x64-gnu: 19.31 MB (16.6%)
  • zod: 10.37 MB (8.9%)
  • ai: 7.01 MB (6.0%)
Installed footprint breakdown
Installed package size
🔴 eve                              [########################] 31.19 MB 26.9%
🔴 @typescript/typescript-linux-x64 [######################..] 27.95 MB 24.1%
🔴 @rolldown/binding-linux-x64-gnu  [###############.........] 19.31 MB 16.6%
🔴 zod                              [########................] 10.37 MB 8.9%
🔴 ai                               [#####...................] 7.01 MB 6.0%
🟠 undici                           [###.....................] 3.51 MB 3.0%
🔴 Other installed packages         [#############...........] 16.79 MB 14.5%
dependencies (4)
Package Range Installed size Share
@vercel/connect 1.0.0 167.9 kB 0.1%
ai ^7.0.82 7.01 MB 6.0%
eve file:eve-0.52.1.tgz 31.19 MB 26.9%
zod 4.5.4 10.37 MB 8.9%
devDependencies (2)
Package Range Installed size Share
@types/node 24.x 2.54 MB 2.2%
typescript 7.0.2 2.50 MB 2.2%
Function Drill-Down

Payload Size Graph

Unique function payload size and share of total
🔴 functions/.well-known/workflow/v1/flow.func     [########################] 10.37 MB 50.0%
🔴 functions/__server.func                         [########################] 10.37 MB 50.0%

Top Function Payloads

🟠 functions/.well-known/workflow/v1/flow.func • 1 public route • 10.37 MB
Metric Value
Public routes /.well-known/workflow/v1/flow
Runtime nodejs24.x
Handler index.mjs
Payload 10.37 MB
Function files 10.37 MB across 112 files
Traced dependencies 0 B
Signal 🟠 Bundled file index.mjs is 2.32 MB (22.4%)

🟠 🔎 Dependency Analysis

📦 Bundled files:

Bundled file size
🟠 index.mjs                        [###########.............] 2.32 MB 22.4%
🟡 _libs/undici.mjs                 [#####...................] 980.8 kB 9.5%
🟡 _chunks/esm-Fqlolk7e.mjs         [###.....................] 723.3 kB 7.0%
🟡 _chunks/chatgpt-model.mjs        [###.....................] 695.8 kB 6.7%
🟡 _chunks/signal-exit-Dsy-TT0V.mjs [###.....................] 616.2 kB 5.9%
🔴 Other bundled files              [########################] 5.03 MB 48.5%

🧾 Vercel Config

{
  "handler": "index.mjs",
  "launcherType": "Nodejs",
  "shouldAddHelpers": false,
  "supportsResponseStreaming": true,
  "runtime": "nodejs24.x",
  "maxDuration": "max",
  "experimentalTriggers": [
    {
      "type": "queue/v2beta",
      "topic": "__eve776561746865722d6167656e74_wkf_workflow_*",
      "consumer": "default",
      "retryAfterSeconds": 5,
      "initialDelaySeconds": 0
    }
  ],
  "environment": {
    "WORKFLOW_PRECONDITION_GUARD": "1"
  }
}

🟠 functions/__server.func • 18 public routes, 1 internal alias • 10.37 MB
Metric Value
Public routes /
/.well-known/workflow/v1/webhook/[token]
/eve/v1/activity/[token]
/eve/v1/callback/[token]
/eve/v1/connections/[name]/callback/[attemptId]/[token]
/eve/v1/connections/[name]/callback/[token]
/eve/v1/health
/eve/v1/info
/eve/v1/session
/eve/v1/session/[parentSessionId]/subagents/[callId]/[childSessionId]/stream
/eve/v1/session/[sessionId]
/eve/v1/session/[sessionId]/cancel
/eve/v1/session/[sessionId]/clear
/eve/v1/session/[sessionId]/compact
/eve/v1/session/[sessionId]/reset
/eve/v1/session/[sessionId]/restore-history
/eve/v1/session/[sessionId]/stream
/eve/v1/task-input/[token]
Internal aliases /__server
Runtime nodejs24.x
Handler index.mjs
Payload 10.37 MB
Function files 10.37 MB across 112 files
Traced dependencies 0 B
Signal 🟠 Bundled file index.mjs is 2.32 MB (22.4%)

🟠 🔎 Dependency Analysis

📦 Bundled files:

Bundled file size
🟠 index.mjs                        [###########.............] 2.32 MB 22.4%
🟡 _libs/undici.mjs                 [#####...................] 980.8 kB 9.5%
🟡 _chunks/esm-Fqlolk7e.mjs         [###.....................] 723.3 kB 7.0%
🟡 _chunks/chatgpt-model.mjs        [###.....................] 695.8 kB 6.7%
🟡 _chunks/signal-exit-Dsy-TT0V.mjs [###.....................] 616.2 kB 5.9%
🔴 Other bundled files              [########################] 5.03 MB 48.5%

🧾 Vercel Config

{
  "handler": "index.mjs",
  "launcherType": "Nodejs",
  "shouldAddHelpers": false,
  "supportsResponseStreaming": true,
  "runtime": "nodejs24.x"
}

Build Timing: e2e/fixtures/agent-tools-sandbox

This is an informational timing measurement inside eve build, from preflight through publication. Output-size measurement and profile writing are excluded.

Build mode: deployable Vercel build with sandbox template prewarm included.

  • Build pipeline: 3.03 s -> 2.87 s (-164.9 ms) vs main (e603739).
  • Timing is informational: shared GitHub runners are too variable for a hard timing budget.
Detailed phase timings vs `main (e603739)`
Phase Baseline Current Delta
extension.check 17.8 ms 15.9 ms -1.9 ms
project.resolve 5.9 ms 0.8 ms -5.1 ms
workspace.create 1.0 ms 9.5 ms +8.5 ms
host.prepare 592.3 ms 466.2 ms -126.1 ms
vercel.service-prefix.resolve 1.8 ms 1.6 ms -0.2 ms
nitro.create 555.3 ms 569.0 ms +13.7 ms
sandbox.prewarm 284.6 ms 259.9 ms -24.7 ms
nitro.cache.prepare 0.2 ms 0.2 ms 0.0 ms
nitro.prepare 0.7 ms 0.7 ms 0.0 ms
nitro.public-assets 0.7 ms 0.7 ms 0.0 ms
nitro.prerender 0.4 ms 0.4 ms 0.0 ms
nitro.bundle 1.52 s 1.49 s -29.1 ms
nitro.cache.write 0.4 ms 0.3 ms -0.1 ms
vercel.workflow-function.materialize 41.3 ms 41.5 ms +0.2 ms
agent-summary.emit 0.7 ms 0.7 ms 0.0 ms
nitro.close 0.1 ms 0.1 ms 0.0 ms
output.publish 3.2 ms 3.2 ms 0.0 ms
workspace.remove 1.8 ms 1.9 ms +0.1 ms

Comment thread packages/eve/src/execution/workflow-steps.ts Outdated
Comment thread packages/eve/src/execution/workflow-steps.ts Outdated
@benpankow
benpankow force-pushed the benpankow/turn-commit-rollback branch from 59f2d1f to 1c87238 Compare September 4, 2026 20:02
@benpankow benpankow changed the title [1/2] feat(eve): add turn commit rollback hooks [1/3] feat(eve): add turn commit rollback hooks Sep 4, 2026
@benpankow
benpankow force-pushed the benpankow/turn-commit-rollback branch from 1c87238 to 7aa2713 Compare September 4, 2026 20:43
@benpankow
benpankow force-pushed the benpankow/turn-commit-rollback branch from 7aa2713 to 4f1c05c Compare September 4, 2026 21:03
@vercel
vercel Bot temporarily deployed to Preview – eve-pkg September 4, 2026 21:03 Inactive
@benpankow
benpankow force-pushed the benpankow/turn-commit-rollback branch from 4f1c05c to 47a2258 Compare September 4, 2026 21:19
Signed-off-by: benpankow <ben.pankow@vercel.com>
Signed-off-by: benpankow <ben.pankow@vercel.com>
Signed-off-by: benpankow <ben.pankow@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant