Skip to content

fix(flags): remove @sveltejs/kit from peer dependencies - #442

Merged
dferber90 merged 1 commit into
mainfrom
k0352
Jul 24, 2026
Merged

fix(flags): remove @sveltejs/kit from peer dependencies#442
dferber90 merged 1 commit into
mainfrom
k0352

Conversation

@dferber90

Copy link
Copy Markdown
Collaborator

@sveltejs/kit was declared as an optional peer with a "*" range, causing npm to auto-install the newest @sveltejs/kit and pull in its transitive @sveltejs/vite-plugin-svelte → vite peer chain. In non-SvelteKit projects already on Vite 7 (via Vitest, Storybook, etc.) this produced a hard ERESOLVE error requiring npm install --force.

Move @sveltejs/kit to devDependencies so the sveltekit entrypoint still builds and type-generates in the monorepo. SvelteKit consumers always have @sveltejs/kit installed as the framework, so flags/sveltekit continues to resolve it from their own tree.

fixes #440

@sveltejs/kit was declared as an optional peer with a "*" range, causing
npm to auto-install the newest @sveltejs/kit and pull in its transitive
@sveltejs/vite-plugin-svelte → vite peer chain. In non-SvelteKit projects
already on Vite 7 (via Vitest, Storybook, etc.) this produced a hard
ERESOLVE error requiring `npm install --force`.

Move @sveltejs/kit to devDependencies so the sveltekit entrypoint still
builds and type-generates in the monorepo. SvelteKit consumers always have
@sveltejs/kit installed as the framework, so flags/sveltekit continues to
resolve it from their own tree.

fixes #440
@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flags-playground Ready Ready Preview, Comment, Open in v0 Jul 24, 2026 2:31pm
flags-sdk-dev Ready Ready Preview, Comment, Open in v0 Jul 24, 2026 2:31pm
flags-sdk-snippets Ready Ready Preview, Comment, Open in v0 Jul 24, 2026 2:31pm
flags-sdk-sveltekit-snippets Ready Ready Preview, Comment, Open in v0 Jul 24, 2026 2:31pm
shirt-shop Ready Ready Preview, Comment, Open in v0 Jul 24, 2026 2:31pm
shirt-shop-api Ready Ready Preview, Comment, Open in v0 Jul 24, 2026 2:31pm

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​radix-ui@​1.6.4971008298100

View full report

@dferber90
dferber90 merged commit 622d56e into main Jul 24, 2026
18 checks passed
@dferber90
dferber90 deleted the k0352 branch July 24, 2026 14:39
@github-actions github-actions Bot mentioned this pull request Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flags transitively pulls a Vite 8 peer dependency via @sveltejs/kit peer-optional, breaking projects on Vite 7

2 participants