fix: preserve absolute URLs in local proxy query params - #60
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kitfoster
changed the title
new URL(loc, 'http://localhost') always yields an http/https URL, so the guard never falsed. Just assign protocol/host unconditionally. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
tim123abc
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #49.
The local proxy was corrupting absolute URLs embedded in query parameters in two places:
replaceAll(/\/[\\/]+/g, '/')ran against the whole URL, collapsinghttps://→https:/inside query strings. Now scoped to the path portion only vianormalizeRepeatedSlashesInPath.Locationrewriting — the non-anchored regex/https:\/\/[^/]+\//could matchhttps://later in the header (inside a query param), not just the upstream origin. Replaced with properURLparsing inrewriteRedirectLocation, which uniformly handles relative and absolute locations and preserves the query without re-corrupting it.Test plan
handleRequestdoes not 307-normalize a request whose query contains an absolute URL.rewriteRedirectLocationcovering both a relative Location with an absolute URL in the query and an absolute upstream Location that needs the origin rewritten back to localhost.