Clarify whether router.pathname includes basePath#24675
Merged
kodiakhq[bot] merged 2 commits intovercel:canaryfrom May 1, 2021
Merged
Clarify whether router.pathname includes basePath#24675kodiakhq[bot] merged 2 commits intovercel:canaryfrom
kodiakhq[bot] merged 2 commits intovercel:canaryfrom
Conversation
tremby
requested review from
divmain,
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
ijjk
reviewed
May 1, 2021
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 1, 2021
The docs were vague on this -- `router.asPath` mentions that it doesn't include `basePath` but `router.pathname` didn't say either way. ## Documentation / Examples - [ ] Make sure the linting passes: I haven't checked; I presume you have a CI bot for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs were vague on this --
router.asPathmentions that it doesn't includebasePathbutrouter.pathnamedidn't say either way.Documentation / Examples