Skip to content

Conversation

@MarDi66
Copy link
Contributor

@MarDi66 MarDi66 commented Jan 25, 2023

Documentation / Examples

Hello Next.js 👋🏼

This PR aims to update the with-apivideo example by:

  • Updating images domain name
  • Switch to export default function for pages
  • Updating the uploader playable and ingested status

What do we use

In this example, we use several Next.js features:

  • Routes and dynamic routes
  • API and dynamic API routes

And api.video tools:

  • NodeJS client
  • React player (instead of our Player SDK)
  • TypeScript uploader

Thank's in advance for your review 🙏🏼

@ijjk ijjk added the examples Issue was opened via the examples template. label Jan 25, 2023
@MarDi66 MarDi66 requested a review from jankaifer as a code owner January 31, 2023 16:08
@MarDi66
Copy link
Contributor Author

MarDi66 commented Feb 1, 2023

FYI: My last commit that aims to update the README is here because when I tried to run the npx create-next-app --example with-apivideo-app command it was not working
npx create-next-app --example with-apivideo works though
Is it normal?

Copy link
Contributor

@jankaifer jankaifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jankaifer
Copy link
Contributor

FYI: My last commit that aims to update the README is here because when I tried to run the npx create-next-app --example with-apivideo-app command it was not working
npx create-next-app --example with-apivideo works though
Is it normal?

Someone just renamed the example and forgot to change the readme.

@kodiakhq kodiakhq bot merged commit 8ad018f into vercel:canary Feb 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

examples Issue was opened via the examples template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants