Skip to content

Conversation

@balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Mar 27, 2024

What?

This adds a script that first gets a list of changed files compared to our base branch (canary) in PRs and identifies related test files by looking them up from a related-tests-manifest.json, then runs them.

Why?

We would like to be able to run related E2E tests when certain files change, so we can test deployment stability.

NOTE: We still want to run all E2E tests on PRs, but this script can be used to also test deployments for hot paths. Since these tests can take up to 3-4 hours, we aim to run a subset of these tests first.

Closes NEXT-2947

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Mar 27, 2024
@ijjk
Copy link
Member

ijjk commented Mar 27, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js chore/test-mapping Change
buildDuration 13.9s 13.9s N/A
buildDurationCached 8.5s 6.2s N/A
nodeModulesSize 199 MB 199 MB
nextStartRea..uration (ms) 379ms 404ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js chore/test-mapping Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.05 kB 5.05 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 243 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/test-mapping Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js chore/test-mapping Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 504 B N/A
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.22 kB 4.22 kB N/A
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.85 kB 1.85 kB
Client Build Manifests
vercel/next.js canary vercel/next.js chore/test-mapping Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/test-mapping Change
index.html gzip 530 B 528 B N/A
link.html gzip 542 B 542 B
withRouter.html gzip 525 B 523 B N/A
Overall change 542 B 542 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js chore/test-mapping Change
edge-ssr.js gzip 95.5 kB 95.5 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js chore/test-mapping Change
middleware-b..fest.js gzip 624 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js chore/test-mapping Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 97.3 kB 97.3 kB
app-page-tur..prod.js gzip 99.1 kB 99.1 kB
app-page-tur..prod.js gzip 93.3 kB 93.3 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.8 kB 91.8 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route.ru...dev.js gzip 21.1 kB 21.1 kB
app-route.ru..prod.js gzip 14.9 kB 14.9 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.5 kB 22.5 kB
server.runti..prod.js gzip 51.3 kB 51.3 kB
Overall change 947 kB 947 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js chore/test-mapping Change
0.pack gzip 1.58 MB 1.58 MB N/A
index.pack gzip 106 kB 107 kB ⚠️ +249 B
Overall change 106 kB 107 kB ⚠️ +249 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: e59538c

@ijjk
Copy link
Member

ijjk commented Mar 27, 2024

Tests Passed

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @balazsorban44 and the rest of your teammates on Graphite Graphite

@balazsorban44 balazsorban44 marked this pull request as ready for review March 27, 2024 15:26
@balazsorban44 balazsorban44 requested a review from a team as a code owner March 27, 2024 15:26
@balazsorban44 balazsorban44 requested a review from styfle April 3, 2024 14:58
styfle
styfle previously approved these changes Apr 4, 2024
@balazsorban44 balazsorban44 dismissed styfle’s stale review April 10, 2024 08:24

Refactoring after off-site discussion to use a single manifest

@balazsorban44 balazsorban44 marked this pull request as draft April 10, 2024 08:24
@balazsorban44 balazsorban44 marked this pull request as ready for review April 10, 2024 14:21
@balazsorban44 balazsorban44 requested review from ijjk and styfle April 10, 2024 14:21
@balazsorban44 balazsorban44 enabled auto-merge (squash) April 11, 2024 07:42
@balazsorban44 balazsorban44 disabled auto-merge April 11, 2024 07:44
@balazsorban44 balazsorban44 merged commit b93ead0 into canary Apr 11, 2024
@balazsorban44 balazsorban44 deleted the chore/test-mapping branch April 11, 2024 07:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

created-by: Next.js team PRs by the Next.js team. locked

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants